Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113859
MIME-Version: 1.0
References: <CAF+90c9A6zG-nYzc3NNtWGjN7y5FmwqnYzjq6GSFC5NtRsOT0w@mail.gmail.com>
 <CAGgaK7JywM+aU4YTK3tUr3xjN5746LDoda4SC_=A+msGdWhNyg@mail.gmail.com> <6c3d7c13-d7cd-c1cc-5876-2b8c200a017c@gmail.com>
In-Reply-To: <6c3d7c13-d7cd-c1cc-5876-2b8c200a017c@gmail.com>
Date: Tue, 30 Mar 2021 12:43:41 +0300
Message-ID: <CAGgaK7JxmLexnkrt+kLfV47wi=KoeqhnzGjTyrcAQtxemKoSKQ@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000a8d2505bebdd6c3"
Subject: Re: [PHP-DEV] Changes to Git commit workflow
From: maxsem.wiki@gmail.com (Max Semenik)

--0000000000000a8d2505bebdd6c3
Content-Type: text/plain; charset="UTF-8"

On Tue, Mar 30, 2021 at 3:29 AM Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> On 3/29/21 4:49 AM, Max Semenik wrote:
> > Would it also make sense if direct pushes (bypassing the pull requests
> > system) were disallowed completely? I can see multiple problems with
> direct
> > pushes:
>
> This is possible. In fact, there are Git bots that make it easier (e.g.
> prow: https://github.com/kubernetes/test-infra/tree/master/prow) - I am
> using such system over Github at my $DAYJOB and it's generally working
> well. It even has its own built-in karma-like system. However, it has
> some downsides, as the experience shows:
>
> 1. Quick management patches, typofixes, release management patches, etc.
> become more high friction processes.
> 2. Setup and configuration of such system involves some time investment
> by some knowledgeable people, and it has certain learning curve (though
> once it is set up, it's pretty easy to use).
> 3. Somebody knowledgeable needs to maintain it, as periodically bots can
> get stuck and need a gentle kick to continue.
> 4. CI needs to be very stable and clean for having CI pass as gateway to
> merge, otherwise a flaky test can block all work in the repo for days.
> 5. Managing multiple active branches can be a pain.
>
> None of these are critical, and we could start small and build it
> incrementally, of course.
>

We don't even have to use bots - GitHub allows you to require passing CI
and/or approving reviews to merge.


-- 
Best regards,
Max Semenik

--0000000000000a8d2505bebdd6c3--