Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:113857 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 85121 invoked from network); 30 Mar 2021 00:32:34 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 30 Mar 2021 00:32:34 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id B57DC1804E4 for ; Mon, 29 Mar 2021 17:29:42 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 29 Mar 2021 17:29:42 -0700 (PDT) Received: by mail-pj1-f51.google.com with SMTP id k23-20020a17090a5917b02901043e35ad4aso8545825pji.3 for ; Mon, 29 Mar 2021 17:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:subject:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=+VQPjNy7zpVXrTAfPBeJJZI9DNdKa6MQG3x7vbpgx/M=; b=anArr+W7d3poOM6mU7BxQD9ieBdg9VA3K7yudZ2MWx2zowTXDW8LwGL6geKILeeEyT Hoe8LA6deFyCnBEeomcJWzZisMg8O2O85x+KVfO+yZoR9Le3Fr6EwOnA/HGiogCA5oEO mHshLHgoS8hzxgjtqAZoK3fvlwDe5/wE6rOqH/prTt6xSyQ2aspk1kgF40UmdsBK8mub rND7EXVTzR3ohwdujMr+rfWOr+uUKdSpgoftxHJKye+Whs1OVQIOJemUztmItKGLmJm2 /ecBihk/ep0AOt2Sk3xkisC20NOMusatUDRfPWzKh6T1lc/+iH6KNYQ6Dckc6Oj2QkOh ALNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+VQPjNy7zpVXrTAfPBeJJZI9DNdKa6MQG3x7vbpgx/M=; b=U6xpl+hoOgWViORsPcUTIOWGTyhKMj93GjqbR1jr+H00PhfnkM84JHhCo9LvK2Kgqm t3H8oHUiO5Nl2OJIu+VCFN0meGoszf4njXbapxFHei5L5vPEs3Dkt2lP33xgjp4w2wJa D4b+zUyWLUNNi21qOSG/xvZqO+3RgtP/+Ub77qFAa9tmLWWddKBZlNvblvK1g0dw1rZA Cl4vs99pAEEZRSfHaYri93MhXxRe3XcLwYRzoStUhjN/FkhP8CFXn+XgzFtwEc9KufAH 9SxFAWy5qs0p9l4OwSuVjr3uKpeiwp3A7AeLe5ehDwVs6sSm8Pqi5R5XURq4axRtIdj3 3a8w== X-Gm-Message-State: AOAM532NgmgrCVNDnj6rImveo6tAVYh39TmSviVvsFWC4lLtbO4x/sQH fa+WkXZ6RRqWKBe01IX43N2EwfheaO+z X-Google-Smtp-Source: ABdhPJxdwdjaSYBlaZBB/XVol9hcqbafUvVAIqGpA6deqhBdRTuOxoQWGIByfuBXGSKF0i3g1HZX8Q== X-Received: by 2002:a17:90a:c201:: with SMTP id e1mr1660172pjt.30.1617064180345; Mon, 29 Mar 2021 17:29:40 -0700 (PDT) Received: from ip-192-168-8-5.us-west-2.compute.internal ([2601:646:8d80:9130::da3f]) by smtp.gmail.com with ESMTPSA id e1sm18733518pfi.175.2021.03.29.17.29.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Mar 2021 17:29:39 -0700 (PDT) To: internals@lists.php.net References: Message-ID: <6c3d7c13-d7cd-c1cc-5876-2b8c200a017c@gmail.com> Date: Mon, 29 Mar 2021 17:29:39 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] Changes to Git commit workflow From: smalyshev@gmail.com (Stanislav Malyshev) Hi! On 3/29/21 4:49 AM, Max Semenik wrote: > On Mon, Mar 29, 2021 at 1:53 AM Nikita Popov wrote: > >> changes should be pushed directly to GitHub rather than to git.php.net. > > > Would it also make sense if direct pushes (bypassing the pull requests > system) were disallowed completely? I can see multiple problems with direct > pushes: This is possible. In fact, there are Git bots that make it easier (e.g. prow: https://github.com/kubernetes/test-infra/tree/master/prow) - I am using such system over Github at my $DAYJOB and it's generally working well. It even has its own built-in karma-like system. However, it has some downsides, as the experience shows: 1. Quick management patches, typofixes, release management patches, etc. become more high friction processes. 2. Setup and configuration of such system involves some time investment by some knowledgeable people, and it has certain learning curve (though once it is set up, it's pretty easy to use). 3. Somebody knowledgeable needs to maintain it, as periodically bots can get stuck and need a gentle kick to continue. 4. CI needs to be very stable and clean for having CI pass as gateway to merge, otherwise a flaky test can block all work in the repo for days. 5. Managing multiple active branches can be a pain. None of these are critical, and we could start small and build it incrementally, of course. -- Stas Malyshev smalyshev@gmail.com