Newsgroups: php.doc,php.internals
Path: news.php.net
Xref: news.php.net php.doc:969387874 php.internals:113848
MIME-Version: 1.0
References: <CAF+90c9A6zG-nYzc3NNtWGjN7y5FmwqnYzjq6GSFC5NtRsOT0w@mail.gmail.com>
 <CAN2symg2SueEONzMRndsWEhj6anXmeAQwKg+HzKh-o61bcP0Qg@mail.gmail.com>
 <CAESVnVoPEitSCzmrAR2pRY4zUp4WEBc3a1b3q4H_uh1q8ebVWw@mail.gmail.com>
 <CACXBjuirpK+Jw4W8ePib3-ZUVe0EgvcxZNeN-Za15E0g-4BwRg@mail.gmail.com> <CAKxcST-hj3Z_Q0divdf3fRb5Ye62cPfQAJTKh3cy+-RePCTr3g@mail.gmail.com>
In-Reply-To: <CAKxcST-hj3Z_Q0divdf3fRb5Ye62cPfQAJTKh3cy+-RePCTr3g@mail.gmail.com>
Date: Mon, 29 Mar 2021 08:59:54 +0100
Message-ID: <CAKxcST8WZ2-VwBN+J_5ZVANA33C2gvcgdhZHo-n5nZXvqpCagw@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Sara Golemon <pollita@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Doc Mailing List <phpdoc@lists.php.net>, PHP internals <internals@lists.php.net>, 
	Paul Crovella <paul.crovella@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000b9a26e05bea84497"
Subject: Re: [PHP-DEV] Changes to Git commit workflow
From: dragoonis@gmail.com (Paul Dragoonis)

--000000000000b9a26e05bea84497
Content-Type: text/plain; charset="UTF-8"

On Mon, 29 Mar 2021, 08:51 Paul Dragoonis, <dragoonis@gmail.com> wrote:

>
>
> On Mon, 29 Mar 2021, 02:30 Rasmus Lerdorf, <rasmus@lerdorf.com> wrote:
>
>> On Sun, Mar 28, 2021 at 17:15 Sara Golemon <pollita@php.net> wrote:
>>
>> > On Sun, Mar 28, 2021 at 6:57 PM Paul Crovella <paul.crovella@gmail.com>
>> > wrote:
>> >
>> >> You might consider requiring commits be signed while you're at it.
>> >>
>> >>
>> > I suggested this as well, and even if we don't require it, we should
>> > STRONGLY encourage it.
>> >
>> > I've been signing my commits for several years now, it's not even that
>> > hard.
>> >
>> I think for php-src commits we can require it. For doc and other repos we
>> can make it optional for now until people are more comfortable with it.
>>
>
> Hey Rasmus,
>
> This is a good compromise.
>
> However, if you leave phpweb repo without signed commits then we're at
> risk from XSS or similar attacks still, and the surface area is really big
> because literally everyone is accessing the site.
>
> Many thanks,
> Paul
>

I also wanted to say; back when I was rebuilding our website a few years
ago, when you pushed to master it would automatically deploy this to the
live site.

If we are compromised and we still automatically roll out to production,
this would make it really easy for someone.

Can someone check how we currently do this, and maybe we should reconsider
auto production deploys, even if its temporary, to be on the safe side.


>
>
>
>> -Rasmus
>>
>

--000000000000b9a26e05bea84497--