Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113844
MIME-Version: 1.0
References: <CAF+90c9A6zG-nYzc3NNtWGjN7y5FmwqnYzjq6GSFC5NtRsOT0w@mail.gmail.com>
 <CAN2symg2SueEONzMRndsWEhj6anXmeAQwKg+HzKh-o61bcP0Qg@mail.gmail.com>
 <CAESVnVoPEitSCzmrAR2pRY4zUp4WEBc3a1b3q4H_uh1q8ebVWw@mail.gmail.com>
 <CACXBjuirpK+Jw4W8ePib3-ZUVe0EgvcxZNeN-Za15E0g-4BwRg@mail.gmail.com> <CAP=4hCLU2CuDKXuJ=XgB=BAL6FARYSq0MeRJqky0GtQw891ZgQ@mail.gmail.com>
In-Reply-To: <CAP=4hCLU2CuDKXuJ=XgB=BAL6FARYSq0MeRJqky0GtQw891ZgQ@mail.gmail.com>
Date: Mon, 29 Mar 2021 09:48:40 +0530
Message-ID: <CANLbj-pbGR9a0QVjHXu+J9Z=xpJnpyjfEYGxQzwmj_NnkqBn4Q@mail.gmail.com>
To: Gabriel Caruso <carusogabriel34@gmail.com>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, Sara Golemon <pollita@php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>, PHP Doc Mailing List <phpdoc@lists.php.net>, 
	PHP internals <internals@lists.php.net>, Paul Crovella <paul.crovella@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Changes to Git commit workflow
From: ayesh@php.watch (Ayesh Karunaratne)

I think this is a great step forward.
With commit signatures required, I think the person who merges a PR
now needs to do so locally. [GitHub CLI](https://cli.github.com/)
helps me a lot to locally checkout a PR quickly, and then
rebase/squash with my own signature.

Thanks to Levi Morrison and Nikita for the very quick response.

>
> On Mon, 29 Mar 2021, 03:30 Rasmus Lerdorf, <rasmus@lerdorf.com> wrote:
>
> > On Sun, Mar 28, 2021 at 17:15 Sara Golemon <pollita@php.net> wrote:
> >
> > > On Sun, Mar 28, 2021 at 6:57 PM Paul Crovella <paul.crovella@gmail.com>
> > > wrote:
> > >
> > >> You might consider requiring commits be signed while you're at it.
> > >>
> > >>
> > > I suggested this as well, and even if we don't require it, we should
> > > STRONGLY encourage it.
> > >
> > > I've been signing my commits for several years now, it's not even that
> > > hard.
> > >
> > I think for php-src commits we can require it. For doc and other repos we
> > can make it optional for now until people are more comfortable with it.
> >
> > -Rasmus
>
>
> >
> > We can require Signed Commits for the main active branches on GitHub:
> > https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-signed-commits
>
>
> We can create rules that requires that for all active maintained version of
> PHP.
>
> We can set that per repo, or in a organization level.
>
> - Gabriel Caruso