Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:113837 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 62250 invoked from network); 28 Mar 2021 19:33:37 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Mar 2021 19:33:37 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 482B21801FD for ; Sun, 28 Mar 2021 12:30:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail02.x-net.at (mail02.x-net.at [83.65.141.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 28 Mar 2021 12:30:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id C2B6438079E for ; Sun, 28 Mar 2021 21:30:24 +0200 (CEST) Received: from mail02.x-net.at ([127.0.0.1]) by localhost (x-zimbra02.x [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id GsM45RKINUdP for ; Sun, 28 Mar 2021 21:30:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id C8F7138071B for ; Sun, 28 Mar 2021 21:30:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at x-t.at Received: from mail02.x-net.at ([127.0.0.1]) by localhost (x-zimbra02.x [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LcNPDYaZncFq for ; Sun, 28 Mar 2021 21:30:23 +0200 (CEST) Received: from x-zimbra02.x (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id B07243800D1 for ; Sun, 28 Mar 2021 21:30:23 +0200 (CEST) Date: Sun, 28 Mar 2021 21:30:23 +0200 (CEST) To: internals Message-ID: <1999047771.337103.1616959823485.JavaMail.zimbra@dafert.at> In-Reply-To: References: <1722754661.329421.1616943259775.JavaMail.zimbra@dafert.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: Zimbra 8.8.15_GA_3959 (ZimbraWebClient - FF87 (Linux)/8.8.15_GA_3953) Thread-Topic: Proposal: add IntlDateTimePatternGenerator Thread-Index: hn8rk83rLL8RPTYF8hKmQN8aLCkWwA== Subject: Re: [PHP-DEV] Proposal: add IntlDateTimePatternGenerator From: mel@dafert.at (Mel Dafert) > Now that I see their implementation again, I'm wondering if `IntlDateTime= PatternGenerator` is the right name, or we should also use `IntlDatePattern= Generator`, which is more in line with `IntlDateFormatter`.=20 I was also wondering about that. I ended up going for `IntlDateTimePatternG= enerator`, because ICU has that same inconsistency (`icu::DateFormat` and `icu::DateTimePatternGenerator`). I think the big argument here is discoverability - if someone is wondering = about whether PHP exposes the feature from ICU, it might be harder to find it if we name it differently (and vice versa). PS: Sorry about the duplicate/badly formatted message - I am new to the con= cept of mailing lists. ----- Original Message ----- From: "M=C3=A1t=C3=A9 Kocsis" To: "Mel Dafert" Cc: "internals" Sent: Sunday, March 28, 2021 7:45:46 PM Subject: Re: [PHP-DEV] Proposal: add IntlDateTimePatternGenerator Hi Mel, Thank you very much for working on this! I was bitten by lack of this functionality a few years ago, and I couldn't find any (good) alternative. Thus, I'm looking forward to having `IntlDateTimePatternGenerator` in ext/intl. I think it could be mentioned for those who don't open the bug report that HHVM implemented this class long ago: https://github.com/facebook/hhvm/commit/bc84daf7816e4cd268da59d535dcadfc6cf= 01085 Now that I see their implementation again, I'm wondering if `IntlDateTimePatternGenerator` is the right name, or we should also use `IntlDatePatternGenerator`, which is more in line with ``IntlDateFormatter`= . Regards: M=C3=A1t=C3=A9 Mel Dafert ezt =C3=ADrta (id=C5=91pont: 2021. m=C3=A1rc. 28= ., V, 16:54):