Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113755
MIME-Version: 1.0
References: <44ac7866-75ef-44ab-a5f9-4e571652b5e6@www.fastmail.com>
In-Reply-To: <44ac7866-75ef-44ab-a5f9-4e571652b5e6@www.fastmail.com>
Date: Wed, 24 Mar 2021 22:12:22 -0700
Message-ID: <CAPrKfG6dmsoHyEndCE2Pv=br0iJurKskNxok9p+Jzvz73VvfFQ@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008af89405be557601"
Subject: Re: [PHP-DEV] [RFC] Short functions, take 2
From: sarkedev@gmail.com (Peter Stalman)

--0000000000008af89405be557601
Content-Type: text/plain; charset="UTF-8"

On Wed, Mar 24, 2021 at 5:40 PM Larry Garfield <larry@garfieldtech.com>
wrote:

> In response to the feedback that the savings in typing volume is small,
> that's true but also not the main point.  The main point is to allow and
> encourage functions to be written an in "expression style", that is, as
> actual functions and not procedures.  As the RFC notes, such use cases are
> increasing, and is likely to increase in PHP, and that's overall a good
> thing for the language.  It fits well with a number of recent RFCs both
> passed and proposed, and makes writing functional-style code much more
> natural.
>

Hi Larry,

I too am wondering about the space saving aspect; as Levi showed it's quite
easy to currently write functions on one line, which really only cost 7
more characters.  Overall though, I am not a fan of the code getting wider,
and the return statements not lining up as I scroll down the code.

As for the "expression style" argument, it's a valid one.  However, I'm
confused why you submitted this RFC hand-in-hand with the multi-statement
auto-capture closures.  Doesn't that contradict the single statement
"expression style" argument?

Overall, I'm not really that much against it, but my only worry is that
while it is slightly less verbose it might create more cluttered code.

Thanks,
Peter

P.S. I also don't like PSR-12.  Allman braces and tabs for life.

--0000000000008af89405be557601--