Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113664
MIME-Version: 1.0
References: <CAH5C8xUqzFJ4V0uo7_FviMq3Sy9Da3MWNMhh+neMO8ZjEnyQWg@mail.gmail.com>
 <B4EABD3F-34C0-495C-8FD0-4646E52C0278@gmail.com> <CAH5C8xXa=ABqCUS+91HvJV=p_q0k00eSjz0uDfqo-5tHhBN5Vg@mail.gmail.com>
 <CAOWwgp=Ado67nQphK0NQ9E=TVvhq8cCSyCog3rhXFTuPNZ+m2w@mail.gmail.com>
 <CAH5C8xXkLZ1weGSZr_VFbRO1gSKZ3CTR9qBE-Z9U_QJXCJDKOA@mail.gmail.com> <CAH5C8xV1AixN=a_d3NCcWk9-01Tr5=nCwxQP9kgwvEPKJvgung@mail.gmail.com>
In-Reply-To: <CAH5C8xV1AixN=a_d3NCcWk9-01Tr5=nCwxQP9kgwvEPKJvgung@mail.gmail.com>
Date: Mon, 22 Mar 2021 13:32:12 +0100
Message-ID: <CAOWwgp=5P98umLMjof5QM6CbKqr8+nE7nvE0MCfykq+AzJizOg@mail.gmail.com>
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000087b1c05be1f4215"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Adding return types to internal methods
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000087b1c05be1f4215
Content-Type: text/plain; charset="UTF-8"

>
> I've updated the RFC with the following things:
> - The proposed error level is now E_DEPRECATED instead of E_STRICT
> - I added a new section for exposing the behavior to userland (this is a
> separate vote)
>

To build on your approach and mixing it with the need we discussed for
userland, I have a new proposal:

We should replace the SuppressReturnTypeNotice by the TentativeReturnType
one right away.
The TentativeReturnType would mean: "I'm going to add a return type to this
method in its next major".
As a consequence, for child classes of internal methods, this would
suppress the notice.
For userland, there are already ways to declare the planned return type
(aka @return in phpdoc), so we might not need any new way to declare this
from the engine pov.
As a corollary, adding this attribute should conflict with having a real
return type.

That would allow userland libs to immediately adopt the tag and be ready
for PHP 8.1.

WDYT?

--000000000000087b1c05be1f4215--