Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113622
MIME-Version: 1.0
References: <CAH5C8xUqzFJ4V0uo7_FviMq3Sy9Da3MWNMhh+neMO8ZjEnyQWg@mail.gmail.com>
 <B4EABD3F-34C0-495C-8FD0-4646E52C0278@gmail.com> <CAH5C8xXa=ABqCUS+91HvJV=p_q0k00eSjz0uDfqo-5tHhBN5Vg@mail.gmail.com>
 <CAOWwgp=Ado67nQphK0NQ9E=TVvhq8cCSyCog3rhXFTuPNZ+m2w@mail.gmail.com>
In-Reply-To: <CAOWwgp=Ado67nQphK0NQ9E=TVvhq8cCSyCog3rhXFTuPNZ+m2w@mail.gmail.com>
Date: Fri, 19 Mar 2021 17:54:18 +0100
Message-ID: <CAH5C8xXkLZ1weGSZr_VFbRO1gSKZ3CTR9qBE-Z9U_QJXCJDKOA@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: Nikita Popov <nikita.ppv@googlemail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ce81ef05bde69193"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Adding return types to internal methods
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--000000000000ce81ef05bde69193
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Nicolas,


> Oh, I didn't get this at first: you're telling that this native return
> type would not be enforced when the attribute is declared? This should
> answer my previous comment.
>

Yes, that's the case. On one hand, this solution IMO has the advantage that
its syntax integrates into the ecosystem much better, including php-src
itself (as I mentioned
in my previous mail). On the other hand, it might be a little bit deceptive
at first that the type declaration is not enforced when the attribute is
present. Nonetheless, I still prefer this solution
over storing types as a list of strings.

I'm not sure yet this is a good idea, because it would prevent userland
> libs from using this attribute in an effective way until they bump to 8.1=
...


The main proposal is about adding return types to internal methods, and the
SuppressReturnTypeNotice attribute can already be added to any libraries.
But you are right in connection with the TentativeReturnType
attribute, libraries would have to bump their minimum PHP version
requirement to 8.1 in order to be able to add return types without a BC
impact on PHP <8.1. I think it's still the less bad option.

As this RFC's primary motivation is to prepare for adding return types to
internal methods, I'm planning to add a secondary vote about exposing
tentative return types to userland, since I'm not 100% confident that this
concept is worth the special care in PHP itself.

M=C3=A1t=C3=A9

--000000000000ce81ef05bde69193--