Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113594
MIME-Version: 1.0
References: <CAF+90c-3dYp8xpEfAGKvECXRh9ySfM23Hyt5xJCiXt0EamQQCQ@mail.gmail.com>
 <CAF+90c9cSvfKf2667xs4Q1joqW5c1wABh8vFxXYfDQ4b4dwHFw@mail.gmail.com>
 <CAAwdEzD87T-6P-XLpHbqNimo+PBURjo+KzM2knPVETYnFOkK9A@mail.gmail.com> <CAF+90c_YfcjbCFcSVwHPUL=xa1_hL2CHeeT2Dv4YqZZrNps=YQ@mail.gmail.com>
In-Reply-To: <CAF+90c_YfcjbCFcSVwHPUL=xa1_hL2CHeeT2Dv4YqZZrNps=YQ@mail.gmail.com>
Date: Wed, 17 Mar 2021 20:56:20 +0200
Message-ID: <CAAwdEzD2oV9Sz++FSeK3N4yqNHZzTgQ_A-fPrfPG1VLHkN0Q9Q@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a88d2705bdc00a8b"
Subject: Re: [PHP-DEV] Re: [RFC] Static variables in inherited methods
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000a88d2705bdc00a8b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 17, 2021, 19:05 Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Wed, Mar 17, 2021 at 5:48 PM Alexandru P=C4=83tr=C4=83nescu <drealecs@=
gmail.com>
> wrote:
>
>>
>> On Wed, Mar 17, 2021 at 5:30 PM Nikita Popov <nikita.ppv@gmail.com>
>> wrote:
>>
>>> On Tue, Feb 23, 2021 at 3:01 PM Nikita Popov <nikita.ppv@gmail.com>
>>> wrote:
>>>
>>> > Hi internals,
>>> >
>>> > While looking into various issues related to static variable handling=
,
>>> > I've become increasingly convinced that our handling of static
>>> variables in
>>> > inherited methods is outright buggy. However, it's also long-standing
>>> > behavior, so I've put up an RFC:
>>> >
>>> > https://wiki.php.net/rfc/static_variable_inheritance
>>> >
>>>
>>> I have now created an implementation for this change, and updated the R=
FC
>>> with some sample code for how one can preserve the old behavior, if it'=
s
>>> being used deliberately. I plan to move forward with voting soon.
>>>
>>
>> Maybe it would be good to have links to some bug reports (that you
>> mentioned) or a code snippet like this https://3v4l.org/J8Mme
>> to clearly show that copying the static variable happens on inheritance
>> point, with whatever that variable was at that point
>> so it would be clear that the current behavior is undefined considering
>> only B class, if it would be to ignore what happened to A in the meantim=
e.
>>
>> Thanks,
>> Alex
>>
>
> We already changed that behavior for PHP 8.1 independently of this RFC --
> static variables will no longer depend on point of inheritance. This RFC =
is
> in addition to that change (and subsumes it really, because point of
> inheritance cannot matter anymore.)
>
> Regards,
> Nikita
>

Right, thanks for explaining. I remembered I saw it on mentioned somewhere
but didn't know exactly where.
Searched it now and it was this PR: https://github.com/php/php-src/pull/670=
5

Thank you,
Alex

--000000000000a88d2705bdc00a8b--