Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113583
MIME-Version: 1.0
References: <D376DEFE-26A4-4F11-8548-D9454087E9FD@trowski.com>
 <70951423-5e77-c150-6dce-dd3c62f8dc8b@php.net> <0b994a60-7970-605b-1657-d6ee732690e5@gmx.de>
 <5C73A1DE-E563-4F69-B8C7-6506F81D7345@trowski.com> <CAKiSzdDVR+joZQQtAS03rAZE_HBZir1CkaBG-BJm6Da1xLnu6A@mail.gmail.com>
 <CANUQDCg-TQCC6LBhDBRvXse2CpVODmM5cK5==a-yMOS09VYeGg@mail.gmail.com>
 <CAKiSzdA+6YK69ez_9kZGACTNMi_e44xX_UPLfDCoU1i0qrF-ew@mail.gmail.com>
 <cc0e0683-2dda-4340-a3b0-6e601882a65f@www.fastmail.com> <CAKiSzdCzXkx_e2ZSbFRFNCd_9F-N_ZZ3-qDMxVZt-jOMMuyVuA@mail.gmail.com>
In-Reply-To: <CAKiSzdCzXkx_e2ZSbFRFNCd_9F-N_ZZ3-qDMxVZt-jOMMuyVuA@mail.gmail.com>
Date: Tue, 16 Mar 2021 20:01:48 -0700
Message-ID: <CAPrKfG5ZoiC02RdgNSP294OFq=kDBDPPOpmN7UTDKhzQah0GhA@mail.gmail.com>
To: Josh Di Fabio <joshdifabio@gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000f25b2905bdb2b4e3"
Subject: Re: [PHP-DEV] [VOTE] Fibers
From: sarkedev@gmail.com (Peter Stalman)

--000000000000f25b2905bdb2b4e3
Content-Type: text/plain; charset="UTF-8"

On Tue., Mar. 16, 2021, 13:58 Josh Di Fabio, <joshdifabio@gmail.com> wrote:

> Fibers will not make those issues obvious at all. The issues I'm
> describing will only crop up spontaneously and under load.
>

Hi Josh,

Is this really that big of a concern though?  The issue will only be a
problem if it's run inside an event loop/scheduler that the concerned
library is compatible with.  In which case the developer should be well
aware of what is involved.

Otherwise, if the library uses fibers internally it will have to resolve
them itself before continuing, no?  If `capturePayment()` starts a fiber
then execution will not get to `setTransactionId()`, until it completed or
is handed of to a scheduler (again, which the developer would be aware of.

So I don't think developers will face this race condition, unless they are
using framework like amphp and reactphp.  But that's already the same now,
so if it's an issue it's not a new one with this RFC.

Your average unaware developer can continue to happily use any libraries
they want without encountering any async issues.  The calls from outside
the library will still be blocking, as PHP will still be single threaded.

Thanks,
Peter

--000000000000f25b2905bdb2b4e3--