Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113454
To: Internals <internals@lists.php.net>
References: <CAKuGYLRjOHWnX24kCVpTUV5DwdVTwcSkakZkZiAmF9YhpGDpVw@mail.gmail.com>
 <75a8a0ec-d988-7712-58b5-88c8061db605@gmail.com>
 <CAKuGYLR1nNMBNJJXnmmJyDQBf=sFVY0beyv_vT8jBuQMrKpcfg@mail.gmail.com>
Message-ID: <6fdee65d-4663-a805-0df6-376edb573f77@gmail.com>
Date: Wed, 10 Mar 2021 20:52:48 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <CAKuGYLR1nNMBNJJXnmmJyDQBf=sFVY0beyv_vT8jBuQMrKpcfg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] noreturn type
From: rowan.collins@gmail.com (Rowan Tommins)

On 10/03/2021 19:21, Matthew Brown wrote:
> If the Zend engine hits that operand — which only happens if a 
> throw/exit *hasn't* been encountered — it emits a TypeError.


Right, that should probably be spelled out in the RFC. Checking at 
run-time in that way is consistent with actual return types, but 
inconsistent with "void", which performs all its checking at compile-time.

On that note, the "comparison to void" section could maybe more clearly 
call out the difference in behaviour, rather than showing the happy path 
for both. If I understand right:

- the "sayHello" function would give an error at runtime if marked 
"noreturn"
- the "redirect" function would run fine if marked "void"
- a function containing "return null;" would fail at compile time for both
- a function containing "return;" would be OK for "void", but fail at 
compile time for "noreturn"?

Regards,

-- 
Rowan Tommins
[IMSoP]