Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113424
Sender: Michael Wallner <mike.php.net@gmail.com>
To: internals@lists.php.net
References: <CABLJ+14_JBZNT8Yj-SKB-CX3Y8LVt-edurR4MQi=xVbzxH1_xw@mail.gmail.com>
Message-ID: <b217a544-6e18-c52d-37a4-594580841b01@php.net>
Date: Tue, 9 Mar 2021 12:03:19 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CABLJ+14_JBZNT8Yj-SKB-CX3Y8LVt-edurR4MQi=xVbzxH1_xw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="KQY8bCffdXdCgP6izHI3Ib339sKFDGWYn"
Subject: Re: [PHP-DEV] Tracking Object Property Changes
From: mike@php.net (Michael Wallner)

--KQY8bCffdXdCgP6izHI3Ib339sKFDGWYn
Content-Type: multipart/mixed; boundary="AsiArKZNFU5tkTSyAsQwVPv1zTiAMjSiE";
 protected-headers="v1"
From: Michael Wallner <mike@php.net>
To: internals@lists.php.net
Message-ID: <b217a544-6e18-c52d-37a4-594580841b01@php.net>
Subject: Re: [PHP-DEV] Tracking Object Property Changes
References: <CABLJ+14_JBZNT8Yj-SKB-CX3Y8LVt-edurR4MQi=xVbzxH1_xw@mail.gmail.com>
In-Reply-To: <CABLJ+14_JBZNT8Yj-SKB-CX3Y8LVt-edurR4MQi=xVbzxH1_xw@mail.gmail.com>

--AsiArKZNFU5tkTSyAsQwVPv1zTiAMjSiE
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: quoted-printable

Hi Joseph!

Is this for educational purposes or real world usage?

I ask, because, if you don't have to adhere to a predefined C-API you
would avoid lots of headache by baking all this stuff into your PHP
objects with the APIs provided by Zend. But then again, it would be way
more efficient to just write it all in PHP code.

More comments following inline.

On 09/03/2021 03.32, Joseph Montanez wrote:
> I am not sure what to title this but the gist is that I have two struct=
s
> with a one way dependency:
>=20
> // Vector3 type
> typedef struct Vector3 {
>     float x;
>     float y;
>     float z;
> } Vector3;
>=20
> // Ray type (useful for raycast)
> typedef struct Ray {
>     Vector3 position;       // Ray position (origin)
>     Vector3 direction;      // Ray direction
> } Ray;

As these are embedded structs instead of pointers to, neither do point
to the memory of the other.


> The PHP Ray object is defined as so:
> typedef struct _skeleton_ray_object {
>     Ray ray;
>     HashTable *prop_handler;
>     zend_object std;
      ^^^^^^^^^^^^^^^^
NOTE: This has to be the last line in your object struct because of an
VLA at the end of the zend_object struct. See your xyz_new() function
where you allocate additional zend_object_properties_size() bytes for
that VLA (variable length array).

>=20
>     skeleton_vector3_object *position;
>     skeleton_vector3_object *direction;
> } skeleton_ray_object;
>=20
> When I update either vector3 object, I don't have a way to propagate th=
e
> changes back to the parent object(Ray). This means the raw Ray struct i=
s
> never updated. Is there a built-in way to handle propagation (listeners=
) in
> a PHP extension or will I need to hand roll this?

Yes, you gotta write all of this on your own, but let me repeat that
this is a lot of boilerplate which also may entail lots of headache.


--=20
Regards,
Mike


--AsiArKZNFU5tkTSyAsQwVPv1zTiAMjSiE--

--KQY8bCffdXdCgP6izHI3Ib339sKFDGWYn
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

wsB5BAABCAAjFiEEHsPHHd1jWDGjN9aESA4+FLCkx8cFAmBHVfcFAwAAAAAACgkQSA4+FLCkx8f/
Pgf/YJS6e5wayGkUy968F0EHGmgbzfJpuyGlG2JMnBLgQtuJYLa6QpKtrkUlYa8dZGgscmhkgx5f
8JDk6TN1WUG0tRg2ZhGbcAAgm2pJXMuHFnoTj7LQ3pH4tvG7jMA0FLJ2QzHhMj2lt9wj/FdOEh8P
sie4hoI653t5KCKr1zHAqq8aiVcw89MzwIjtC9HPFo/DNYgZi2vvWJxFznoQP8llQ1GWUYkwfShi
sfp4eFLcMdWcrijOZPrCq+mNrCkLWxdK+2HV8uWN0R5aAnDq1UyaBGAUhMEXp8u5AdRGrY6rucue
XZP5gYkyivWIcikir3gXp9pk7ZRofumaVcuPqFR9Tg==
=taXz
-----END PGP SIGNATURE-----

--KQY8bCffdXdCgP6izHI3Ib339sKFDGWYn--