Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11341 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39485 invoked by uid 1010); 19 Jul 2004 10:12:59 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 39461 invoked from network); 19 Jul 2004 10:12:58 -0000 Received: from unknown (HELO mproxy.gmail.com) (216.239.56.247) by pb1.pair.com with SMTP; 19 Jul 2004 10:12:58 -0000 Received: by mproxy.gmail.com with SMTP id w29so4279112cwb for ; Mon, 19 Jul 2004 03:12:58 -0700 (PDT) Received: by 10.11.99.11 with SMTP id w11mr145260cwb; Mon, 19 Jul 2004 03:12:58 -0700 (PDT) Message-ID: <4e89b42604071903121e312e1c@mail.gmail.com> Date: Mon, 19 Jul 2004 11:12:58 +0100 To: Jakub Vrana Cc: internals@lists.php.net, Michele Locati In-Reply-To: <4431765562.20040719105602@vrana.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <4431765562.20040719105602@vrana.cz> Subject: Re: [PHP-DEV] Case sensitivity of require_once From: kingwez@gmail.com (Wez Furlong) Did you test require_once under PHP 5 yet? (without your patch) --Wez. On Mon, 19 Jul 2004 10:56:02 +0200, Jakub Vrana wrote: > File a.php is required twice with this code on Windows: > require_once "a.php"; > require_once "A.php"; > ?> > > Should I document this behavior or should patch similar to this be > applied? > > Index: zend_execute.c > =================================================================== > RCS file: /repository/Zend/Attic/zend_execute.c,v > retrieving revision 1.316.2.38 > diff -u -r1.316.2.38 zend_execute.c > --- zend_execute.c 12 Jul 2004 17:47:32 -0000 1.316.2.38 > +++ zend_execute.c 19 Jul 2004 08:48:44 -0000 > @@ -2148,6 +2148,10 @@ > file_handle.opened_path = estrndup(inc_filename->value.str.val, inc_filename->value.str.len); > } > > +#ifdef ZEND_WIN32 > + zend_str_tolower(file_handle.opened_path, strlen(file_handle.opened_path)); > +#endif > + > if (zend_hash_add(&EG(included_files), file_handle.opened_path, strlen(file_handle.opened_path)+1, (void *)&dummy, sizeof(int), NULL)==SUCCESS) { > new_op_array = zend_compile_file(&file_handle, (EX(opline)->op2.u.constant.value.lval==ZEND_INCLUDE_ONCE?ZEND_INCLUDE:ZEND_REQUIRE) TSRMLS_CC); > zend_destroy_file_handle(&file_handle TSRMLS_CC); > > -- > Jakub Vrana > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >