Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113374
To: internals@lists.php.net
References: <CAFPFaMJJrOvVQn4K-34ApqFy83Ge4wZ79QwvcQaZkavEdr4Lbg@mail.gmail.com>
Message-ID: <31987585-0286-1e0a-adcb-51d2edec0145@gmx.net>
Date: Thu, 4 Mar 2021 14:23:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <CAFPFaMJJrOvVQn4K-34ApqFy83Ge4wZ79QwvcQaZkavEdr4Lbg@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------7C3602E86E01CA8F81A42DEC"
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Deprecate implicit non-integer-compatible float
 to int conversions
From: a.leathley@gmx.net (Andreas Leathley)

--------------7C3602E86E01CA8F81A42DEC
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 04.03.21 14:07, G. P. B. wrote:
> This new version of the RFC can be found on the wiki: [2]
> https://wiki.php.net/rfc/implicit-float-int-deprecate

I like the RFC, but I think the diagnostic messages will be hard to
understand when they come up in real scripts, especially because they
can be platform-dependent and can have two different reasons, and
"non-compatible" is not self-explanatory. Giving a very specific message
would be more helpful for people experiencing these errors, something like=
:

  * Implicit conversion to int from float(-string) with fractional part
  * Implicit conversion to int from float(-string) which is outside of
    int range (=3D> maybe also mentioning the range of the platform)

(Maybe there are additional possible errors to consider, but those two
seem two obvious possibilities)


--------------7C3602E86E01CA8F81A42DEC--