Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113344
To: internals@lists.php.net
References: <BFDC5ABE-3155-4C4D-84DE-0FB1D9B37D32@9dev.de>
 <09ef54b2-a6b1-5bf5-8562-f2f436fd4d92@processus.org>
 <9BF1EB68-3F1F-4FBF-A87F-FADF98B09E4A@9dev.de>
 <CA+hqhpd6RH4J9a+QhFuw-YUXU2SuCCa1pQXz0TcZANrHNtk3pA@mail.gmail.com>
 <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>
 <b5de38ba-125e-536b-b9e9-60cc1342e876@heigl.org>
 <434CA771-46ED-4219-A360-CC7E4A34EDDE@9dev.de>
Message-ID: <471b9142-7df6-6d64-0814-035f6e8252e1@heigl.org>
Date: Wed, 3 Mar 2021 14:42:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <434CA771-46ED-4219-A360-CC7E4A34EDDE@9dev.de>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="BjHqS45jwpn99GksxsBZyEs8gwZBg4wtJ"
Subject: Re: [PHP-DEV] Add __toString() to DateInterval
From: andreas@heigl.org (Andreas Heigl)

--BjHqS45jwpn99GksxsBZyEs8gwZBg4wtJ
Content-Type: multipart/mixed; boundary="YmRGiVjf0OX9cR7GqAkGzVENj1dondRhN";
 protected-headers="v1"
From: Andreas Heigl <andreas@heigl.org>
To: internals@lists.php.net
Message-ID: <471b9142-7df6-6d64-0814-035f6e8252e1@heigl.org>
Subject: Re: [PHP-DEV] Add __toString() to DateInterval
References: <BFDC5ABE-3155-4C4D-84DE-0FB1D9B37D32@9dev.de>
 <09ef54b2-a6b1-5bf5-8562-f2f436fd4d92@processus.org>
 <9BF1EB68-3F1F-4FBF-A87F-FADF98B09E4A@9dev.de>
 <CA+hqhpd6RH4J9a+QhFuw-YUXU2SuCCa1pQXz0TcZANrHNtk3pA@mail.gmail.com>
 <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>
 <b5de38ba-125e-536b-b9e9-60cc1342e876@heigl.org>
 <434CA771-46ED-4219-A360-CC7E4A34EDDE@9dev.de>
In-Reply-To: <434CA771-46ED-4219-A360-CC7E4A34EDDE@9dev.de>

--YmRGiVjf0OX9cR7GqAkGzVENj1dondRhN
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable


Am 03.03.21 um 14:24 schrieb Moritz Friedrich:
>=20
>=20
>> Am 03.03.2021 um 14:01 schrieb Andreas Heigl <andreas@heigl.org>:
>>
>> I'd rather see those classes as ValueObjects that should not have to
>> take care about their external representation. And a custom Formatter
>> that handles all the weird edge cases as a separate entity would be a
>> much easier to maintain approach. And such a Formatter can easily be
>> build in userland (I think I wrote one myself at one point) and so the=

>> maintenance-burden would also not be added to internals.
>>
>> That would also apply to the DateTimeInterval::format() method but tha=
t
>> would mean a massive BC break so it is most likely out of the question=
=2E
>> Nevertheless I would prefer an external library to handle all those
>> formatting issues and treat the DateTime lib as internal ValueObjects
>=20
> I=E2=80=99d like to respectfully disagree. If we were to go down the Va=
lueObject route, DateTime/DateInterval should not be able to create new i=
nstances from formatted strings in the first place. PHP Date classes have=
 always been intertwined with their output formatting however, so this is=
 how the ecosystem uses them. In that sense, I=E2=80=99d expect DateInter=
val to be able to return the format it was instantiated with, but it isn'=
t.

Well. ValueObjects should be able to create new Instances of themselves
via factory methods. But that would mean a lot of tweaking at perhaps no
added benefit.

But TBH: DateTimeImmutable:fromString() instead of new
DateTimeImmutable() would be awesome... Or even better:
DateTime::fromString() with DateTimeImmutable as return type


> The PHP API may have its warts, but I prefer my warts consistent.

I feel you.

As the other Objects have a format() method why not have a format method
for DatePeriod as well? It does not need to take a parameter as there
are no different formats (at least that I could think of).

But I would rather not add more magic (methods) to PHP...

Cheers

Andreas

--=20
                                                              ,,,
                                                             (o o)
+---------------------------------------------------------ooO-(_)-Ooo-+
| Andreas Heigl                                                       |
| mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=B0=
23'58" |
| https://andreas.heigl.org                                           |
+---------------------------------------------------------------------+
| https://hei.gl/appointmentwithandreas                               |
+---------------------------------------------------------------------+


--YmRGiVjf0OX9cR7GqAkGzVENj1dondRhN--

--BjHqS45jwpn99GksxsBZyEs8gwZBg4wtJ
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOHo7et0VdZk8RJK34Ff+SCK3tkUFAmA/kjgACgkQ4Ff+SCK3
tkVPLw/+Nl9PPbHpPHQcRO+hZJlyVM+J/qCezyp91cV9w4QpQ2NLVUAoYaPK/JmD
CGBwvjYdg1zAQ6iesO5eUEnUhiM2a5nuUhYv340nHC+lBdNnDNJppsBBHsZgQyFP
1hzB9fEMQ9MSroDFhpSXIaST8DgAm0BDaiVILT0EpU3sPOjlq6zT2iW1VONal+mQ
5LCAtOGF2v3BhZZFkpSpZa7IVqXtt8GPkM0r5501apVZYXBC4zSOo1eNwj52TKB4
+RlkKy2YuZCPDKlB7VjEkGxaw9QAxjqnw4XotTDWvnpC71AuAJmzlqwfSK/jT3Nv
+G/n0bWufroqd3ydmtz5WxmuRTrI2JouNq1UVBL9bmN19y50RCtQ87rFkhZXIB/u
28BWa9Vezf2VN8heC78r5zexyj3JojO8Canb7ijUGGwQJg3Qqqi4glaT2Ms1tT/m
xdEvgVITGcVM2+1O40VKJaihKUbaO37jCSdlOtY18mLOqvju9zHCYlbimwJzHSAo
KlMqTXePaDl4uK3vB8XPeOGNb/FRUJ41bmvHzCLBYLvsZwzGb2IvK8bTq+t+9xRV
LyngDY1+ylKRpZ7YUZR5hBfFjimXct/v7yUenottx+FETEtiBfEKI3HBNgMAnTL2
mnAVA47bQJzTlr0yhY+W22fWhU1olzpCgcFS1Y3BgpDQoOrUPcg=
=R4XT
-----END PGP SIGNATURE-----

--BjHqS45jwpn99GksxsBZyEs8gwZBg4wtJ--