Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113342
To: internals@lists.php.net
References: <BFDC5ABE-3155-4C4D-84DE-0FB1D9B37D32@9dev.de>
 <09ef54b2-a6b1-5bf5-8562-f2f436fd4d92@processus.org>
 <9BF1EB68-3F1F-4FBF-A87F-FADF98B09E4A@9dev.de>
 <CA+hqhpd6RH4J9a+QhFuw-YUXU2SuCCa1pQXz0TcZANrHNtk3pA@mail.gmail.com>
 <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>
Message-ID: <b5de38ba-125e-536b-b9e9-60cc1342e876@heigl.org>
Date: Wed, 3 Mar 2021 14:01:10 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="gEUI3KwBInxG9Xt9SDTubdSDHos9A7xwO"
Subject: Re: [PHP-DEV] Add __toString() to DateInterval
From: andreas@heigl.org (Andreas Heigl)

--gEUI3KwBInxG9Xt9SDTubdSDHos9A7xwO
Content-Type: multipart/mixed; boundary="zbdkNzvCScF2dl1qXOnwSJdlHTgXxRx1T";
 protected-headers="v1"
From: Andreas Heigl <andreas@heigl.org>
To: internals@lists.php.net
Message-ID: <b5de38ba-125e-536b-b9e9-60cc1342e876@heigl.org>
Subject: Re: [PHP-DEV] Add __toString() to DateInterval
References: <BFDC5ABE-3155-4C4D-84DE-0FB1D9B37D32@9dev.de>
 <09ef54b2-a6b1-5bf5-8562-f2f436fd4d92@processus.org>
 <9BF1EB68-3F1F-4FBF-A87F-FADF98B09E4A@9dev.de>
 <CA+hqhpd6RH4J9a+QhFuw-YUXU2SuCCa1pQXz0TcZANrHNtk3pA@mail.gmail.com>
 <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>
In-Reply-To: <CAJmy8YHmJ-0WvbOoSL4w9yv3LHU5aRzNVWYutCXyNVX56uNuSw@mail.gmail.com>

--zbdkNzvCScF2dl1qXOnwSJdlHTgXxRx1T
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Hey

Am 03.03.21 um 13:05 schrieb Hans Henrik Bergan:
> if FWIW if DateTime::__toString() was just
> function __toString():string{
>     return $this->format(\DateTime::RFC3339);
> }
>=20
> i certainly wouldn't complain.
>=20
> On Wed, 3 Mar 2021 at 12:16, Bruce Weirdan <weirdan@gmail.com> wrote:
>=20
>> On Wed, Mar 3, 2021 at 1:07 PM Moritz Friedrich <m@9dev.de> wrote:
>>
>>> but I=E2=80=99m not too fond of the constant - all other built-in dat=
e constants
>>> translate to a string of plain format characters, which isn=E2=80=99t=
 possible in
>>> this case
>>
>>
>> Adding another format character (similar to %c used by
>> DateTimeInterface::format()) would solve that.

I'd rather see those classes as ValueObjects that should not have to
take care about their external representation. And a custom Formatter
that handles all the weird edge cases as a separate entity would be a
much easier to maintain approach. And such a Formatter can easily be
build in userland (I think I wrote one myself at one point) and so the
maintenance-burden would also not be added to internals.

That would also apply to the DateTimeInterval::format() method but that
would mean a massive BC break so it is most likely out of the question.
Nevertheless I would prefer an external library to handle all those
formatting issues and treat the DateTime lib as internal ValueObjects

Cheers

Andreas

--=20
                                                              ,,,
                                                             (o o)
+---------------------------------------------------------ooO-(_)-Ooo-+
| Andreas Heigl                                                       |
| mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=B0=
23'58" |
| https://andreas.heigl.org                                           |
+---------------------------------------------------------------------+
| https://hei.gl/appointmentwithandreas                               |
+---------------------------------------------------------------------+


--zbdkNzvCScF2dl1qXOnwSJdlHTgXxRx1T--

--gEUI3KwBInxG9Xt9SDTubdSDHos9A7xwO
Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="OpenPGP_signature"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEOHo7et0VdZk8RJK34Ff+SCK3tkUFAmA/iJgACgkQ4Ff+SCK3
tkVnXg/+JSbN6fFHDBQB4vZvRcigen4LeSOr2XdxOHzL+tQ5ReVQEFcXeY0AYVWd
tFYXQvjDCkFibK5mucTCg38aL+N+TKU0nbXgcTLvI7/N5XnB8xiTmrnktMLJ3/tw
WQ2W7pZKjvduPUfozaVrEkFpE52TsBo86N6Le6MTvimoeIopdE3aRB/2bD8avoeh
PFIP5LySKPloZwqblj6vs8Bh1MRrI0JoDL6z6zF+/HxbJiM+Cj2bd/Tc30y8PCxu
5AHp4Rom3F6bIO1Mce0oc+CVDCPhD1MOWbR8BoGX8Ha7sf/mjOTjVXt2jEfJrcy8
eVEF5GEf76x2MF70ARwygM/w6cgzaKFIU1RuuY7c+vShPXYfMD6ESfaWLXgvkkS1
V1g3ClrlIiOqVZEqhXdifZNsvW32Pzi9JKIgF7kdkWTA9d7wtTlllPSFxzk4q8SB
Je1uG8zdiRW0/y6/zK/EGExriLivAc6ZyA77QR0iuFQ4kRD2feoBxlXTXzhrGFsb
rHkAknz71Vw2sHQERQeAgw5Wk72aKWi0gciNpjjeUgLRQkd2NqjVXaAOirfmKT0P
Q43LCfW+gKBYi2YYIzk3HCNw1wuWHCnhIOI1IcuotGuaogdDe7E+UjPpzGQwiipw
hV9lau+czw3E90X8mkTZpJua1u3jcH5EwJ6UwSonTTQirnReXfo=
=4U/A
-----END PGP SIGNATURE-----

--gEUI3KwBInxG9Xt9SDTubdSDHos9A7xwO--