Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113317
MIME-Version: 1.0
References: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au>
 <6EC89E9A-035D-4D2B-97D7-845DC4FF3E32@koalephant.com> <CA+p1FaYJbD5Yyximj5LDdZmeCaxV_p1wnqyb9mfe=Bz9E-LVoA@mail.gmail.com>
 <e6a89e88-bbb3-91b7-e138-66719ba1f8c4@processus.org> <347e565f-f90a-5fc6-efcf-e28856ad00dc@gmail.com>
 <23cf71d2-4fed-ceab-6c63-c826af01bb36@processus.org> <06b75517-ecdd-c409-e6ca-3a7ed14fb628@gmail.com>
In-Reply-To: <06b75517-ecdd-c409-e6ca-3a7ed14fb628@gmail.com>
Date: Sat, 27 Feb 2021 20:00:37 +0000
Message-ID: <CAGBsUrfFZsGb5XLgndwGfrjEaaNRz0qwM=i5Qd922urF_xj3sQ@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000047ea1905bc56d74c"
Subject: Re: [PHP-DEV] PDO integer changes in 8.1 will stop many websites I support
From: tekiela246@gmail.com (Kamil Tekiela)

--00000000000047ea1905bc56d74c
Content-Type: text/plain; charset="UTF-8"

Hi Matthew,

As was pointed out before ZEROFILL is getting deprecated. It has been
deprecated by MySQL and I assume MariaDB will follow soon.
The change you are referring to is only to fix inconsistency in PHP. The
problem with ZEROFILL has been present since forever as far as I know.

The setting PDO::ATTR_STRINGIFY_FETCHES is not going to affect the result
either, because the value isn't stored with zeros. The length of integers
columns only signifies how MySQL displays it in the result.

Storing non-numerical values like phone numbers or zip codes in integer
columns is just a terrible idea. If the zip code has a leading zero that is
part of the data then it should be stored in a text column. MySQL doesn't
store the leading zeros. It only pads the output.

If you want you can always cast the number to a character SELECT
CAST(`ZEROFILL` as CHAR)  FROM `zerofill` which will tell MySQL to pad the
output.

The change that Nikita did is the correct one. As to whether PHP should do
anything with regards to ZEROFILL_FLAG is a separate question.

Re Pierre's confusion: I believe you are confusing prepared statements with
emulation of prepared statements, but this is orthogonal to this
discussion.

Kind Regards,
Kamil

--00000000000047ea1905bc56d74c--