Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113315
MIME-Version: 1.0
References: <CAGBsUreh+N1h2tK_RDFcT_m3cTFDY7KZBF1L3hi_ZQzSwcWS9w@mail.gmail.com>
 <8D73024D-E4DB-4D04-A917-3B399E65D495@gmail.com>
In-Reply-To: <8D73024D-E4DB-4D04-A917-3B399E65D495@gmail.com>
Date: Sat, 27 Feb 2021 18:53:55 +0000
Message-ID: <CAGBsUrcQVdpeTTa1E3ijJF67ZccKx_tbTcStFm4fGT1EutBPRg@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b4808905bc55e88a"
Subject: Re: [PHP-DEV] [RFC] mysqli bind in execute
From: tekiela246@gmail.com (Kamil Tekiela)

--000000000000b4808905bc55e88a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 25 Feb 2021 at 08:35, Claude Pache <claude.pache@gmail.com> wrote:

>
> Hi,
>
> In the paragraph =E2=80=9CDifference between PDO and mysqli=E2=80=9D, you=
 propose:
>
> =E2=80=9CArray keys are completely ignored. mysqli doesn't have emulated =
prepares
> nor does it have named parameters.=E2=80=9D
>
> Instead of ignoring the keys, I think it is better to throw a TypeError
> when the provided array is not a =E2=80=9Clist=E2=80=9D in the sense of `=
array_is_list()`
> introduced [in a recent RFC] (https://wiki.php.net/rfc/is_list). The
> reasons are:
>
> * provide the user with useful feedback when they are attempting to do
> something dubious and/or their intent is ambiguous;
> * be forward compatible with possible future addition of named parameters=
;
> * reduce the difference with PDO for input that are accepted in both
> mysqli and PDO.
>
> =E2=80=94Claude
>
>
 Hi Claude,

Thanks for the feedback. I thought about it and I have to say I honestly do
not know which way would be better. I haven't received any other comments
so far. What you are proposing makes sense, but I don't know how to
implement this. I am not so experienced with PHP internals so I would
require some help to add such an error.

The only other comments I have seen so far are from Reddit
https://www.reddit.com/r/PHP/comments/llntv5/php_rfc_mysqli_bind_in_execute=
/

I could add another voting option for people to decide whether they want
the keys to be ignored or if they want an error. I appreciate it if anyone
has any other comments about this proposal too.

Kind Regards,
Kamil

--000000000000b4808905bc55e88a--