Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113314
To: PHP internals <internals@lists.php.net>
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <CAF+90c8GDMs5f0i27n8gGNx_TvwqKH9CqsW8eSgEf+8mGrdyZA@mail.gmail.com>
 <84a86f15-313e-1fb3-eb09-7fd6bbdeb5ce@php.net>
 <821813eb972cd5dad30a0e10385a115a9a8908a2.camel@schlueters.de>
 <CAGBsUrfF5Xk+ne6fo46EivKN82OQeM=0yAcPe5r2y9-ZgPEYrw@mail.gmail.com>
 <2d9e003c-2a05-9cfa-8625-5aedf5b069f6@gmail.com>
 <CAGBsUrf2CNq33sQ1HLCAkzT+P1BaykYPfmf4Wsx0MZNtZUz+MQ@mail.gmail.com>
 <445707c1-2b67-1f46-8d93-d9e0ca420b87@gmail.com>
 <CAGBsUrdiBXDGg9ibbLyxcMobvohRev3SPi_doFMTp=dELOnKMw@mail.gmail.com>
Message-ID: <dbd4e86c-c22a-655a-439a-f2b66fc97256@gmail.com>
Date: Sat, 27 Feb 2021 18:40:25 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <CAGBsUrdiBXDGg9ibbLyxcMobvohRev3SPi_doFMTp=dELOnKMw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: rowan.collins@gmail.com (Rowan Tommins)

On 27/02/2021 18:10, Kamil Tekiela wrote:
>
>     Select * From products Where product_id = 'hello world'
>
>     If product_id is a column of type int, then the database will raise an
>     error about incompatible types.
>
>
> No, this query would produce a warning. I am unaware of an SQL mode 
> that would turn this warning into an error.


Right, I forgot we were talking about MySQL, which has the same "ignore 
and carry on" tradition as PHP; in other DBMSes, that would be an error:

PostgreSQL:

 > ERROR: invalid input syntax for type integer: "hello world"
 > LINE 1: Select * From products Where product_id = 'hello world';

Microsoft SQL Server:

 > Msg 245 Level 16 State 1 Line 1
 > Conversion failed when converting the varchar value 'hello world' to 
data type int.


However, the main point of the example was to show that an error could 
go unnoticed, and actually have no immediate negative effects, such that 
replacing it with an exception makes things worse.



> Examples, that would truly be effected are something like this:
>
> $stmt = $mysqli->query('INSERT INTO tableA (uniqueColumn) 
> VALUE("repeated value")');
> if (1062 === $mysqli->errno) {
>     echo "Can't add this value because it already exists!";
> }
>
> If the developer didn't silence the errors then the user will see a 
> generic error instead of the specific one.


Precisely, and this is what people are concerned about: if someone is 
writing code from scratch, exception-by-default is a good thing; but if 
they have existing error handling, by-passing that handling by throwing 
an exception is not.


Regards,

-- 
Rowan Tommins
[IMSoP]