Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113311
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <CAF+90c8GDMs5f0i27n8gGNx_TvwqKH9CqsW8eSgEf+8mGrdyZA@mail.gmail.com>
 <84a86f15-313e-1fb3-eb09-7fd6bbdeb5ce@php.net> <821813eb972cd5dad30a0e10385a115a9a8908a2.camel@schlueters.de>
 <CAGBsUrfF5Xk+ne6fo46EivKN82OQeM=0yAcPe5r2y9-ZgPEYrw@mail.gmail.com>
 <2d9e003c-2a05-9cfa-8625-5aedf5b069f6@gmail.com> <CAGBsUrf2CNq33sQ1HLCAkzT+P1BaykYPfmf4Wsx0MZNtZUz+MQ@mail.gmail.com>
 <445707c1-2b67-1f46-8d93-d9e0ca420b87@gmail.com>
In-Reply-To: <445707c1-2b67-1f46-8d93-d9e0ca420b87@gmail.com>
Date: Sat, 27 Feb 2021 18:10:43 +0000
Message-ID: <CAGBsUrdiBXDGg9ibbLyxcMobvohRev3SPi_doFMTp=dELOnKMw@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000403afb05bc554e3c"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: tekiela246@gmail.com (Kamil Tekiela)

--000000000000403afb05bc554e3c
Content-Type: text/plain; charset="UTF-8"

>
> Select * From products Where product_id = 'hello world'
>
> If product_id is a column of type int, then the database will raise an
> error about incompatible types.
>

No, this query would produce a warning. I am unaware of an SQL mode that
would turn this warning into an error. Maybe I am wrong and there is a way
to convert this into an error, but that would be pointless.
I believe you have chosen the wrong example. That query, even when executed
with PDO, doesn't throw an exception.

The point of this RFC is that mysqli should treat SQL errors the same way
that PDO does. By default, all errors should be reported. An error in SQL
is the same as an exception in PHP code; it means that something went
terribly wrong. I have been using PDO for a few years now and I never had a
need to silence its error reporting. SQL doesn't spit out exceptions
randomly.

Examples, that would truly be effected are something like this:

$stmt = $mysqli->query('INSERT INTO tableA (uniqueColumn) VALUE("repeated
value")');
if (1062 === $mysqli->errno) {
    echo "Can't add this value because it already exists!";
}

If the developer didn't silence the errors then the user will see a generic
error instead of the specific one.

--000000000000403afb05bc554e3c--