Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113303
MIME-Version: 1.0
References: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au>
In-Reply-To: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au>
Date: Sat, 27 Feb 2021 16:32:23 +0100
Message-ID: <CAF+90c9+H88HaOby6D1oHvBFORHcs2azRpU5-+O-z_TPABSCOg@mail.gmail.com>
To: Matty The Mad <matty@themad.com.au>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000057c98305bc53186f"
Subject: Re: [PHP-DEV] PDO integer changes in 8.1 will stop many websites I support
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000057c98305bc53186f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 27, 2021 at 9:50 AM Matty The Mad <matty@themad.com.au> wrote:

> PHP 8.1 PDO has been changed so that when MySQL returns an integer it
> will no longer be returned as a string, but as an int.
>
> The problem is this breaks any sites that use UNSIGNED ZEROFILL integer
> fields in MySQL.
>
> I support a number of websites where the phone numbers and post codes
> are all UNSIGNED ZEROFILL.
>
> The post codes in MySQL are stored as 0800.
>
> In PHP 8.0 returned as string 0800
> In PHP 8.1 returned as integer 800
>
> 8.0.2
> string(10) "0742000000"
>
> 8.1.0-dev
> int(742000000)
>
> PDO shouldn't really be changing the data.
>
> I propose that:
> =E2=80=A2 any ZEROFILL integers are returned as string [or]
> =E2=80=A2 there's an option to control this when making the connection (I=
 don't
> want to str_pad() at every place I've used ZEROFILL in the past) [or]
> =E2=80=A2 this backwards compatibility breaking change is removed until P=
HP 9.
>
> Matthew Asia
>

To clarify, what changed in PHP 8.1 is that emulated prepares now produce
the same results as native prepares. Or from a technical perspective, that
you get the same results independently of whether the text protocol or the
binary protocol is used to communicate with the MySQL server.

The handling of ZEROFILL does look like a bug to me. We should return
values with leading zeros as strings for both protocols. For reference,
this issue is tracked at https://bugs.php.net/bug.php?id=3D80808.

Regards,
Nikita

--00000000000057c98305bc53186f--