Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113297
MIME-Version: 1.0
References: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au> <6EC89E9A-035D-4D2B-97D7-845DC4FF3E32@koalephant.com>
In-Reply-To: <6EC89E9A-035D-4D2B-97D7-845DC4FF3E32@koalephant.com>
Date: Sat, 27 Feb 2021 13:18:24 +0000
Message-ID: <CA+p1FaYJbD5Yyximj5LDdZmeCaxV_p1wnqyb9mfe=Bz9E-LVoA@mail.gmail.com>
To: Stephen Reay <php-lists@koalephant.com>
Cc: Matty The Mad <matty@themad.com.au>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000cf16f805bc513855"
Subject: Re: [PHP-DEV] PDO integer changes in 8.1 will stop many websites I support
From: davidgebler@gmail.com (David Gebler)

--000000000000cf16f805bc513855
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Apologies, in respect of point 1 in my reply, I misread your original
message and didn't realise you were referring to the upcoming 8.1 change,
thought you were referring to the current 8.0.1 release.

This change AFAIK only affects emulated prepares and is an improvement, as
previously you needed to have emulation off to get the correct data types.
With modern PHP, MySQL and mysqnd there is not really a reason for anyone
to be using emulated prepares anyway so my advice on points 2-5 remains the
same.

Dave

On Sat, Feb 27, 2021 at 12:55 PM Stephen Reay <php-lists@koalephant.com>
wrote:

>
> > On 27 Feb 2021, at 15:56, Matty The Mad <matty@themad.com.au> wrote:
> >
> > =EF=BB=BFPHP 8.1 PDO has been changed so that when MySQL returns an int=
eger it
> will no longer be returned as a string, but as an int.
> >
> > The problem is this breaks any sites that use UNSIGNED ZEROFILL integer
> fields in MySQL.
> >
> > I support a number of websites where the phone numbers and post codes
> are all UNSIGNED ZEROFILL.
> >
> > The post codes in MySQL are stored as 0800.
> >
> > In PHP 8.0 returned as string 0800
> > In PHP 8.1 returned as integer 800
> >
> > 8.0.2
> > string(10) "0742000000"
> >
> > 8.1.0-dev
> > int(742000000)
> >
> > PDO shouldn't really be changing the data.
> >
> > I propose that:
> > =E2=80=A2 any ZEROFILL integers are returned as string [or]
> > =E2=80=A2 there's an option to control this when making the connection =
(I don't
> want to str_pad() at every place I've used ZEROFILL in the past) [or]
> > =E2=80=A2 this backwards compatibility breaking change is removed until=
 PHP 9.
> >
> > Matthew Asia
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php
> >
>
> I agree it should be configurable, but storing digit strings as integers
> is asking for trouble.
>
> Edit: Whoops, sending again from on-list address.
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000cf16f805bc513855--