Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113296
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
In-Reply-To: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au>
Date: Sat, 27 Feb 2021 19:55:33 +0700
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <6EC89E9A-035D-4D2B-97D7-845DC4FF3E32@koalephant.com>
References: <499c2591-fb11-1b9d-d402-39f7ec1c6b85@themad.com.au>
To: Matty The Mad <matty@themad.com.au>
Subject: Re: [PHP-DEV] PDO integer changes in 8.1 will stop many websites I
 support
From: php-lists@koalephant.com (Stephen Reay)


> On 27 Feb 2021, at 15:56, Matty The Mad <matty@themad.com.au> wrote:
>=20
> =EF=BB=BFPHP 8.1 PDO has been changed so that when MySQL returns an =
integer it will no longer be returned as a string, but as an int.
>=20
> The problem is this breaks any sites that use UNSIGNED ZEROFILL =
integer fields in MySQL.
>=20
> I support a number of websites where the phone numbers and post codes =
are all UNSIGNED ZEROFILL.
>=20
> The post codes in MySQL are stored as 0800.
>=20
> In PHP 8.0 returned as string 0800
> In PHP 8.1 returned as integer 800
>=20
> 8.0.2
> string(10) "0742000000"
>=20
> 8.1.0-dev
> int(742000000)
>=20
> PDO shouldn't really be changing the data.
>=20
> I propose that:
> =E2=80=A2 any ZEROFILL integers are returned as string [or]
> =E2=80=A2 there's an option to control this when making the connection =
(I don't want to str_pad() at every place I've used ZEROFILL in the =
past) [or]
> =E2=80=A2 this backwards compatibility breaking change is removed =
until PHP 9.
>=20
> Matthew Asia
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>=20

I agree it should be configurable, but storing digit strings as integers =
is asking for trouble.

Edit: Whoops, sending again from on-list address.=