Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113262
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Marco Pivetta <ocramius@gmail.com>, David Gebler <davidgebler@gmail.com>,
 PHP internals <internals@lists.php.net>
References: <CA+p1Fabcg4Xm_1WUXS=TqfwqU-cWCH9zpF63cwTON--ZjZ8YDg@mail.gmail.com>
 <CA+p1Fabwm2RnkQAYdUaDkhFVO+teZE=TwYFjQijSDrjqykSOww@mail.gmail.com>
 <CADyq6s+_kGPgBarkqmw5BJR9QiDkaQ+Dq4PcPTc=kBF+FVQdtg@mail.gmail.com>
 <dae35ab4-fd45-1ad6-c9ff-e7feffcadcf0@gmx.de>
 <CAF+90c_L-0k1Ji0YmVSB_5DNk8mjaJzsRVoUo6vSmD=wx_15zA@mail.gmail.com>
Message-ID: <629736ee-074e-8059-f60f-8700c8f55a92@gmx.de>
Date: Thu, 25 Feb 2021 13:12:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <CAF+90c_L-0k1Ji0YmVSB_5DNk8mjaJzsRVoUo6vSmD=wx_15zA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] fsync function
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 25.02.2021 at 13:03, Nikita Popov wrote:

> On Thu, Feb 25, 2021 at 1:01 PM Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
>
>> On 25.02.2021 at 12:43, Marco Pivetta wrote:
>>> Hey David,
>>> <http://ocramius.github.com/>
>>>
>>>
>>> On Wed, Feb 24, 2021 at 6:15 PM David Gebler <davidgebler@gmail.com>
>> wrote:
>>>
>>>> Voting is now open for 2 weeks on
>> https://wiki.php.net/rfc/fsync_function
>>>>
>>>> Regards,
>>>> David Gebler
>>>>
>>>> On Tue, Feb 23, 2021 at 5:15 PM David Gebler <davidgebler@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi internals,
>>>>> As there appear to be no objections or concerns, I intend to open
>> voting
>>>>> on https://wiki.php.net/rfc/fsync_function tomorrow and voting will
>>>>> remain open for two weeks.
>>>>>
>>>>> The RFC and its implementation
>>>>>
>>>>> - Adds functions fsync() and fdatasync() for plain file streams on U=
nix
>>>>> systems.
>>>>> - Adds function fsync() on Windows with fdatasync() available as an
>> alias
>>>>>
>>>>> PR ref https://github.com/php/php-src/pull/6650
>>>>
>>>
>>> Just clarifying on my "NO" vote: I'm opposed to having more E_WARNING
>>> raised by the language.
>>>
>>> We have better approaches for that:
>>>
>>>  * exceptions
>>>  * union types
>>>  * Maybe/Either types
>>>
>>> I don't see a reason to introduce a warning here, and it makes the
>> function
>>> unusable unless some poor soul implements a library that gets rid of t=
he
>>> warning.
>>
>> Note that *this* warning is never supposed to occur in production,
>> because it is a programming error to pass a wrong resource *type*.
>> Rasing a warning for wrong resource types is standard behavior of
>> zend_fetch_resource() (unless no resource type name is passed).  I don'=
t
>> see why these new functions should use a non standard mechanism.
>>
>> Of course, in the long run resources should go away, which would resolv=
e
>> this issue for these functions as well.
>>
>
> A wrong resource type will throw a TypeError as usual -- the warning is
> thrown if the resource is of the correct type (stream), but does not
> support sync operations. For example, if you tried to do an fsync on an
> http:// stream.

Ah, thanks for the correction!  (I'm doing too much PHP 7, still.)

> Throwing a warning in such a case is consistent with how functions for
> other optional stream operations work.

ACK.

=2D-
Christoph