Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113259
MIME-Version: 1.0
References: <CA+p1Fabcg4Xm_1WUXS=TqfwqU-cWCH9zpF63cwTON--ZjZ8YDg@mail.gmail.com>
 <CA+p1Fabwm2RnkQAYdUaDkhFVO+teZE=TwYFjQijSDrjqykSOww@mail.gmail.com>
In-Reply-To: <CA+p1Fabwm2RnkQAYdUaDkhFVO+teZE=TwYFjQijSDrjqykSOww@mail.gmail.com>
Date: Thu, 25 Feb 2021 12:43:45 +0100
Message-ID: <CADyq6s+_kGPgBarkqmw5BJR9QiDkaQ+Dq4PcPTc=kBF+FVQdtg@mail.gmail.com>
To: David Gebler <davidgebler@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000afaf4405bc27aaed"
Subject: Re: [PHP-DEV] [VOTE] fsync function
From: ocramius@gmail.com (Marco Pivetta)

--000000000000afaf4405bc27aaed
Content-Type: text/plain; charset="UTF-8"

Hey David,
<http://ocramius.github.com/>


On Wed, Feb 24, 2021 at 6:15 PM David Gebler <davidgebler@gmail.com> wrote:

> Voting is now open for 2 weeks on https://wiki.php.net/rfc/fsync_function
>
> Regards,
> David Gebler
>
> On Tue, Feb 23, 2021 at 5:15 PM David Gebler <davidgebler@gmail.com>
> wrote:
>
> > Hi internals,
> > As there appear to be no objections or concerns, I intend to open voting
> > on https://wiki.php.net/rfc/fsync_function tomorrow and voting will
> > remain open for two weeks.
> >
> > The RFC and its implementation
> >
> > - Adds functions fsync() and fdatasync() for plain file streams on Unix
> > systems.
> > - Adds function fsync() on Windows with fdatasync() available as an alias
> >
> > PR ref https://github.com/php/php-src/pull/6650
>

Just clarifying on my "NO" vote: I'm opposed to having more E_WARNING
raised by the language.

We have better approaches for that:

 * exceptions
 * union types
 * Maybe/Either types

I don't see a reason to introduce a warning here, and it makes the function
unusable unless some poor soul implements a library that gets rid of the
warning.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--000000000000afaf4405bc27aaed--