Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113254
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
In-Reply-To: <CAGBsUreh+N1h2tK_RDFcT_m3cTFDY7KZBF1L3hi_ZQzSwcWS9w@mail.gmail.com>
Date: Thu, 25 Feb 2021 09:35:56 +0100
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <8D73024D-E4DB-4D04-A917-3B399E65D495@gmail.com>
References: <CAGBsUreh+N1h2tK_RDFcT_m3cTFDY7KZBF1L3hi_ZQzSwcWS9w@mail.gmail.com>
To: Kamil Tekiela <tekiela246@gmail.com>
Subject: Re: [PHP-DEV] [RFC] mysqli bind in execute
From: claude.pache@gmail.com (Claude Pache)


> Le 11 f=C3=A9vr. 2021 =C3=A0 20:43, Kamil Tekiela =
<tekiela246@gmail.com> a =C3=A9crit :
>=20
> Hi internals,
>=20
> I am proposing the next change to improve mysqli extension. This RFC's =
goal
> is to add a new optional parameter to mysqli_stmt:execute() that will =
take
> an array of parameters.
>=20
> The RFC is located at https://wiki.php.net/rfc/mysqli_bind_in_execute
>=20
> I'd be happy to hear your comments.
>=20
> Kind Regards,
> Kamil Tekiela

Hi,

In the paragraph =E2=80=9CDifference between PDO and mysqli=E2=80=9D, =
you propose:

=E2=80=9CArray keys are completely ignored. mysqli doesn't have emulated =
prepares nor does it have named parameters.=E2=80=9D

Instead of ignoring the keys, I think it is better to throw a TypeError =
when the provided array is not a =E2=80=9Clist=E2=80=9D in the sense of =
`array_is_list()` introduced [in a recent RFC] =
(https://wiki.php.net/rfc/is_list). The reasons are:

* provide the user with useful feedback when they are attempting to do =
something dubious and/or their intent is ambiguous;
* be forward compatible with possible future addition of named =
parameters;
* reduce the difference with PDO for input that are accepted in both =
mysqli and PDO.

=E2=80=94Claude