Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113210
MIME-Version: 1.0
References: <CAH5C8xW981Fn91HsHmZfbLseXwSyOtM1X5u1zsAL4ofXhka=nw@mail.gmail.com>
 <CAF+90c-KZwhkSjrKqKNtLWtMZuhFSQreJpAbZaKApOwmdTf7mQ@mail.gmail.com>
In-Reply-To: <CAF+90c-KZwhkSjrKqKNtLWtMZuhFSQreJpAbZaKApOwmdTf7mQ@mail.gmail.com>
Date: Fri, 19 Feb 2021 00:46:27 +0100
Message-ID: <CAH5C8xX0j_iA5+kHmHt4Z6vyuYs5q8-ktAbunyPrKba8L3Mr5w@mail.gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000056894a05bba4f2d3"
Subject: Re: [PHP-DEV] [RFC] [Discussion] Measuring maximum execution time
 based on wall-time
From: kocsismate90@gmail.com (=?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=)

--00000000000056894a05bba4f2d3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Nikita,

Something potentially worth pointing out (and assuming I'm inferring the
> correct behavior here): If max_execution_wall_time is exceeded during an
> internal function call (which seems quite likely, as that's where there i=
s
> the most potential for something to hang) and the function does not retur=
n
> within hard_timeout seconds, then the a process abort will be triggered.
> The hard_timeout is 2s by default. If any of the individual call timeouts
> are >=3D 2s, then it's not unlikely that this situation occurs.
>

Thanks for bringing this to my attention, I didn't realize this
consequence. I'm wondering though if it would be a sane idea to use the
current,
CPU time based timer for hard_limit even when max_execution_wall_time times
out? This way the process abort could be avoided in case of
most functions in question, if I got it right. Nevertheless, I'll update
the RFC with its relation to hard_timeout in the coming days.

As I'd like to proceed with this RFC soon, I'd appreciate any review and
constructive feedback. I have two questions for example:
- Is the max_execution_wall_time really the best setting name we can come
up with? What about something like max_execution_real_time?
- Would anyone miss a set_wall_time_limit() function?

Regards:
M=C3=A1t=C3=A9

--00000000000056894a05bba4f2d3--