Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113183
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
In-Reply-To: <458846A1-950A-404F-BD75-BD70F73D3625@trowski.com>
Date: Mon, 15 Feb 2021 11:54:10 -0600
Cc: Benjamin Eberlei <kontakt@beberlei.de>,
 php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <F54383AD-A440-4A8B-9B79-1BE3080C7750@trowski.com>
References: <E4BE4688-3CD1-4CE8-A818-5A862F0293F5@trowski.com>
 <CAEPJdumcsPXRxZCFDbFUBN+2JaEt0piYY0Cptu5pAShLStYBFA@mail.gmail.com>
 <9BF046F2-4799-4CCD-A7F0-739A91C77E83@trowski.com>
 <CAAKU0umwKnNe9kKzpk0tGZ7yWyOPdxjUHOXoU2cEiE3LZJbZPQ@mail.gmail.com>
 <458846A1-950A-404F-BD75-BD70F73D3625@trowski.com>
To: Levi Morrison <levi.morrison@datadoghq.com>
Subject: Re: [PHP-DEV] [RFC] Fibers
From: aaron@trowski.com (Aaron Piotrowski)


> On Feb 3, 2021, at 11:32 AM, Aaron Piotrowski <aaron@trowski.com> =
wrote:
>=20
>=20
>> On Jan 31, 2021, at 11:29 AM, Levi Morrison via internals =
<internals@lists.php.net> wrote:
>>=20
>> I think it would probably be advantageous to have an observer that
>> alerts interested parties when the fiber switches. This way we can
>> avoid querying the current fiber on every fcall.
>>=20
>=20
> Hi Levi,
>=20
> Yes, I agree and will look at implementing an observer API.
>=20
> Cheers,
> Aaron Piotrowski
>=20
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php =
<https://www.php.net/unsub.php>

Hi Levi,

I implemented an observer that notifies registered handlers whenever the =
current fiber context is switched.

typedef void (*zend_observer_fiber_switch_handler)(zend_fiber *from, =
zend_fiber *to);
PHP_FIBER_API void =
zend_observer_fiber_switch_register(zend_observer_fiber_switch_handler =
handler);

This works similar to the error observer API.

zend_fiber provides access to a unique ID, zend_execute_data, etc. that =
should be sufficient for code profilers, debuggers, etc. One pointer is =
NULL if {main} is the from or to fiber. The handlers are invoked before =
switching to the fiber and after suspending from a fiber.

Let me know if there=E2=80=99s something missing or improvements that =
could be made.

Cheers,
Aaron Piotrowski=