Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113164
MIME-Version: 1.0
References: <CAEsg9X2Zshqw1bHE7rNey6VotvKgs1i8+zJGSmFp-+JWPnJrww@mail.gmail.com>
In-Reply-To: <CAEsg9X2Zshqw1bHE7rNey6VotvKgs1i8+zJGSmFp-+JWPnJrww@mail.gmail.com>
Date: Sat, 13 Feb 2021 04:11:26 +0100
Message-ID: <CADyq6sJArRg1HDhKG0gYPJYZjyHtf+Cjiiv9OA+YhbvZz1dB5Q@mail.gmail.com>
To: David Rodrigues <david.proweb@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000067cbcb05bb2f1ccd"
Subject: Re: [PHP-DEV] Inline conditional that returns null if falsy
From: ocramius@gmail.com (Marco Pivetta)

--00000000000067cbcb05bb2f1ccd
Content-Type: text/plain; charset="UTF-8"

Hey David,

On Fri, Feb 12, 2021, 20:24 David Rodrigues <david.proweb@gmail.com> wrote:

> Hello!
>
> It is just a suggestion to be discussed.
>
> A lot of places on my projects I have codes like:
>
> $companies = $user->companies->count()
>     ? new Collection($user->companies)
>     : null;
>

Even upfront, this looks like a quite bad idea: either you have an empty
collection, or you have a collection with elements in it, but `null` is a
very different concept that isn't homogeneous with the resulting type.

I've updated multiple projects in the past where `array|null` was used as
return type for a collection-alike endpoint, removing `null` and replacing
it with an empty iterable instead.

>

--00000000000067cbcb05bb2f1ccd--