Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113156
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
In-Reply-To: <303C832F-CAE7-44F4-B879-33C054825953@cschneid.com>
Date: Fri, 12 Feb 2021 16:16:53 +0000
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <A5C298B6-AEF3-4257-BFF3-97AFB8810E96@craigfrancis.co.uk>
References: <CAGBsUreDc1CgpBawb6LNXMzpjK_9Y3LQW9n4jYB9AaDjmD9n-g@mail.gmail.com>
 <5D0AC588-7BBC-419D-BFEA-06E2E112D3F8@cschneid.com>
 <CAJvSBVPUT7fUC8OEAwzQdrByiTbV0cSnqUKNxkgjrynQ8JeZ8g@mail.gmail.com>
 <BDE6D497-965D-477E-9D6F-16F9C9E45F52@craigfrancis.co.uk>
 <303C832F-CAE7-44F4-B879-33C054825953@cschneid.com>
To: Christian Schneider <cschneid@cschneid.com>
Subject: Re: [PHP-DEV] [VOTE]: Change Default mysqli Error Mode
From: craig@craigfrancis.co.uk (Craig Francis)

On 12 Feb 2021, at 15:17, Christian Schneider <cschneid@cschneid.com> =
wrote:
>=20
> Am 12.02.2021 um 15:30 schrieb Craig Francis =
<craig@craigfrancis.co.uk>:
>> Switching the default from `OFF` to `ERROR` to `ERROR | STRICT` isn't =
an obvious step, as that still means you're still having a single step =
to change from error reporting to exceptions.
>=20
> It is the usual step for (almost) all BC breaking changes in PHP: Warn =
first (leaving time to find and adapt code), explode later.
> The question is not *if* the change has to be made (or how big it is) =
but *when* (and how to find places to be changed).



Oh, I completely agree, but Nikita's solution gives a better warning =
about the change to using exceptions.

As in, it would warn that mysqli_report() needs to be used, to specify =
the reporting mode you want, before the default changes.

Going via `MYSQLI_REPORT_ERROR` first, well, it doesn't exactly warn =
about that (it kinda moves forward a bit, but it doesn't warn that =
exceptions will be the new default in 8.2).

Craig





I know you know this already, I'm only including this as a note to self, =
to check how these changes will affect this example code:

    $db =3D new mysqli('localhost', 'user', 'password', 'db');
    $result =3D $db->query('SELECT COUNT(id) FROM invalid_table');
    if ($result) {
        print_r(mysqli_fetch_assoc($result));
    } else {
        print_r('Error');
    }

Currently this just prints 'Error'.

Step 1) Using `MYSQLI_REPORT_ERROR` would add a warning; and then =
continue to print 'Error' - it's not really that different, maybe more =
error messages are shown or logged, but it still works in the same way.

Step 2) Using `MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT` is the =
big-ish change, because it will now throw an exception, and the error =
(which ideally won't happen in the first place) needs to be handled in a =
completely different way.

That said, we are talking about what happens when something goes wrong, =
and generally speaking, that shouldn't happen on an already running =
system... which is why I'm fairly happy with the change that Kamil is =
proposing.

And I should note, maybe phpMyAdmin is an oddity here, because I will =
make typos, and those need to be handled properly, and, erm, phpMyAdmin =
doesn't currently use mysqli_report().