Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113140
MIME-Version: 1.0
References: <1db192c8-5783-863d-880f-fbf2877e84bd@stuart.id.au>
In-Reply-To: <1db192c8-5783-863d-880f-fbf2877e84bd@stuart.id.au>
Date: Thu, 11 Feb 2021 14:41:19 +0000
Message-ID: <CAFPFaMKqPz6OmeVrT_hXLybx-LvchhWitMOgEhdhpQtJRVGrvA@mail.gmail.com>
To: Russell Stuart <russell+lists.php.net@stuart.id.au>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000df229b05bb10831f"
Subject: Re: [PHP-DEV] Requesting RFC karma for your wiki account.
From: george.banyard@gmail.com ("G. P. B.")

--000000000000df229b05bb10831f
Content-Type: text/plain; charset="UTF-8"

On Thu, 11 Feb 2021 at 02:03, Russell Stuart <
russell+lists.php.net@stuart.id.au> wrote:

> I'm created a branch to php-src that makes pdo_firebird::getColumnMeta()
> return "native_type" in addition to "pdo_type".  It also fixes a bug in
> the current getColumnMeta() (of the SIG_SEGV variety), and adds a unit
> test getColumnMeta() for it.  There is none currently.
>
> The branch is here:
>
>
> https://github.com/rstuart/php-src/tree/0044.1-add-pdo-firebird-getcolumnmeta.patch
>
> If I get RFC karma, I will create an RFC and a pull request for it.
>
> --
> Regards,
> Russell Stuart
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>
I don't think this would need an RFC as the MySQL PDO driver went through
the same change.
Have you opened a PR against php/php-src?

Best regards,

George P. Banyard

--000000000000df229b05bb10831f--