Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113138
To: Brent Roose <brendt@stitcher.io>, PHP Internals <internals@lists.php.net>
References: <F68B8FB8-AFE3-4A3B-A1FF-5003B3BA0628@stitcher.io>
Message-ID: <41ae6041-676a-2945-9580-e25bcb96a19b@gmx.de>
Date: Thu, 11 Feb 2021 13:27:00 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <F68B8FB8-AFE3-4A3B-A1FF-5003B3BA0628@stitcher.io>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Changes to finfo and imap functions
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 11.02.2021 at 05:57, Brent Roose wrote:

> The chagelog for PHP 8.1 lists the two following changes:
>
>
> - Fileinfo:
>   . The fileinfo functions now accept and return, respectively, finfo ob=
jects
>     instead of resources.
>
> - IMAP:
>   . The IMAP functions now accept and return, respectively, IMAPConnecti=
on objects
>     instead of resources.
>
> I suppose these changes are part of the move away from "resources everyw=
here" ? I was wondering whether these function will still accept resource =
objects in PHP 8, or if support for them is completely removed.
>
> I tried searching externals.io <http://externals.io/> for a previous dis=
cussion but could only find https://externals.io/message/111297#111298 <ht=
tps://externals.io/message/111297#111298>

Yes, these changes fall under the general resource to object conversion
(which is IMO generally a very good move), and the respective resources
are completely removed.  However, it seems that the incompatibility is
not only wrt. is_resource() checks, which can easily be resolved (and
may not be an issue for some code bases), but also regarding conversion
to int.  It might be sensible to implement cast_object handlers for
those classes, which may be deprecated.

The SSH2 extension would need particular attention in this regard, since
it deliberately uses resource to int/string conversion for its wrappers,
and even looks up the resources from the regular_list[1].

[1]
<https://github.com/php/pecl-networking-ssh2/blob/93265d71bdeb23350e832012=
6c7949ed791310df/ssh2_fopen_wrappers.c#L26-L36>

=2D-
Christoph