Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113121
MIME-Version: 1.0
References: <DM6PR07MB66189594D6D3B6D820E4A5FBF98F9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <77dfe9e5-a6d1-4a41-bceb-454a65cf34d0@www.fastmail.com> <DM6PR07MB6618999C8F1AAC35BF2F8C87F98F9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <f1abc6fd-dfad-4cd4-a124-58475312fa86@www.fastmail.com> <DM6PR07MB66184FDB329A71B371883C54F98E9@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB66184FDB329A71B371883C54F98E9@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Tue, 9 Feb 2021 00:37:42 +0000
Message-ID: <CAGBsUrcJDkQKJnKV1XrLksJi64Uvhja9XQr21KHHMCm8wZ+D2w@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001dab1905badc7fc1"
Subject: Re: [PHP-DEV] [VOTE] PHP\iterable\any() and all() on iterables
From: tekiela246@gmail.com (Kamil Tekiela)

--0000000000001dab1905badc7fc1
Content-Type: text/plain; charset="UTF-8"

Hi Tyson,

Thanks for the RFC. I have to say that I like the core concept and the
motivation behind it. However, let me explain why I voted No.

1. As others have said I think that the scope is too small. If we are going
to create that namespace then I would like to see more functions/classes in
that namespace.
2. I don't like the name. I know the namespace might provide some guidance
of what the function is, but namespaces are often imported. What we are
left with in the code is then `any()`/`all()` that doesn't have a
self-describing name. any_values is better but still doesn't describe the
action that the function will take. I am a strong believer that methods and
functions should be called with verbs which describe an action. e.g.
search, filter, combine, merge, etc. There can always be exceptions but
there should be a good reason to justify such an exception.
3. I am unclear about the implementation itself. There aren't that many
clear examples in the RFC. For example, I don't understand why the second
parameter is nullable and optional. How is it different from array_filter?
4. Please, no more loose checks. I don't want to have the same trouble as
with `in_array()`.

Kind Regards,
Kamil

--0000000000001dab1905badc7fc1--