Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113103
To: internals@lists.php.net
References: <CAFPFaMKDELHFr44kOncQWeCi7KZUL7XLNL2JyvJvmNLTgjDBOQ@mail.gmail.com>
 <CAG9XoMTc-7axJBQu2Skt6ng+6pU4o7gsXy+J47C5EeXyZLmZ=A@mail.gmail.com>
 <ecf37ece-51a9-5b41-5e68-cbcea3786e29@allenjb.me.uk>
 <CAG9XoMTsgrQetKA9jkZC9-pxq7aYSgS3FEWLPMmTjSE_vS70GA@mail.gmail.com>
 <CA+p1FaaB-84BteyC6k0EMqUFwsDmozsAYys9ZYKsr34DBgQ7=Q@mail.gmail.com>
 <CAG9XoMS2C8miP2-wEPYBOT6q+5CAs2y4E_5cQuGYg7y6yf-o9A@mail.gmail.com>
 <248543D8-4266-4495-9FC4-762A63625A93@cschneid.com>
Message-ID: <0d04114d-d90a-913d-627e-16006ec655ef@gmail.com>
Date: Sat, 6 Feb 2021 19:32:04 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <248543D8-4266-4495-9FC4-762A63625A93@cschneid.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Warning for implicit float to int conversions
From: rowan.collins@gmail.com (Rowan Tommins)

On 06/02/2021 14:47, Christian Schneider wrote:
> I'm sure there is a lot of code which takes user input and uses (int) casts to ensure they are dealing with integers.
> There is also intval() as an alternative but my guess would be that real world code uses 50% (int) and 50% intval() to do this.


My thoughts exactly. Code along these lines is common and, in my 
opinion, perfectly reasonable:

$id = (int)$_GET['id'];
if ( $id !== 0 ) {
      // throw an exception, return false, look up a default, etc, as 
the application's design requires
}
// proceed knowing that $id is a non-zero integer


I would however welcome a new function or syntax that either performs a 
"strict cast" (producing an error if the cast is lossy in any way) or 
checks in advance if a cast *would be* lossy.

Regards,

-- 
Rowan Tommins
[IMSoP]