Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113081
To: internals@lists.php.net
References: <CAFPFaMKDELHFr44kOncQWeCi7KZUL7XLNL2JyvJvmNLTgjDBOQ@mail.gmail.com>
 <CAG9XoMTc-7axJBQu2Skt6ng+6pU4o7gsXy+J47C5EeXyZLmZ=A@mail.gmail.com>
Message-ID: <c6f45639-e136-9f46-714d-f99b70dc3098@gmail.com>
Date: Thu, 4 Feb 2021 19:06:40 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <CAG9XoMTc-7axJBQu2Skt6ng+6pU4o7gsXy+J47C5EeXyZLmZ=A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Warning for implicit float to int conversions
From: rowan.collins@gmail.com (Rowan Tommins)

On 04/02/2021 17:54, Benjamin Morel wrote:
> $age = $_GET['age']; // '25.75'
> $x = (int) $foo; // I'd expect a warning, not a silent conversion to 25


If we want to make explicit casts "fussy", that would be a much bigger 
change. Right now, the following are all valid, with no warnings, even 
though they are all lossy conversions:

     (int)25.75,
     (int)"25.75",
     (int)"hello",
     (int)"99 red balloons",
     (bool)2,
     (bool)"yes",
     (float)"3.1415 is not pi",
     (string)M_PI, // calling this "lossy" is a bit of a stretch, but it 
will retain decimal rather than binary precision


There's a case to be made for "strict casts" - I've pointed out before 
that so-called "strict types" mode encourages users to write code that 
is actually *less* strict, because explicit casts are very forgiving. 
However, they should probably be a new syntax, because there will be an 
ENORMOUS amount of code using deliberately using the existing casts in 
lossy situations.

Regards,

-- 
Rowan Tommins
[IMSoP]