Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113069
MIME-Version: 1.0
References: <CA+p1FabAAnBqsK_ZqjJU8od=bFQEXHkKKKx4GCrAvsJXd13HLw@mail.gmail.com>
 <CA+p1FaZjKcCJTOjaXn--__mFmS2EhhmkWtj5ms5rTFm=Gr7V+Q@mail.gmail.com> <CA+p1FaazTesxkSkjt7Wj=Ok=_U8JwFTG-qH=zkfNYt8JbM3n5w@mail.gmail.com>
In-Reply-To: <CA+p1FaazTesxkSkjt7Wj=Ok=_U8JwFTG-qH=zkfNYt8JbM3n5w@mail.gmail.com>
Date: Wed, 3 Feb 2021 17:46:58 +0000
Message-ID: <CA+p1FaYGNQ7rP7NciTwdw+AvybuzTxa_jjcOmGVkv0FUgw=n6A@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001699ef05ba722dc7"
Subject: Re: [RFC]: fsync function
From: davidgebler@gmail.com (David Gebler)

--0000000000001699ef05ba722dc7
Content-Type: text/plain; charset="UTF-8"

RFC ref: https://wiki.php.net/rfc/fsync_function
PR ref: https://github.com/php/php-src/pull/6650

I think this one is pretty much good now and passing builds; when I first
proposed adding fsync some time ago, there was a suggestion from a couple
contributors that an RFC might be overkill/unnecessary for this feature
(and I'd certainly be happy for it to just be accepted as a pull request)
but want to make sure everyone has had a good chance to look over the RFC
and implementation and specifically whether anyone has any significant
concerns or objections?

Thanks.

Dave

On Mon, Feb 1, 2021 at 5:35 PM David Gebler <davidgebler@gmail.com> wrote:

> Hi internals,
> I have updated the GitHub PR and wiki RFC to also include an
> implementation of fdatasync.
>
> On another note, I note my PR builds are failing on MACOS_DEBUG_NTS with a
> test in ext/zend_test/tests/observer_error_05.phpt- this does not appear
> to be related to my changes and I'm wondering if anyone can shed any light
> on this? I'm seeing it on some other open PRs too so I'm guessing it's a
> known issue? Cheers.
>
> David Gebler
> davidgebler@gmail.com
>
>
> On Sat, Jan 30, 2021 at 6:34 PM David Gebler <davidgebler@gmail.com>
> wrote:
>
>> Updated the PR https://github.com/php/php-src/pull/6650 following
>> comment from Nikita, added basic tests, would appreciate further review
>> from contributors, have updated the RFC
>> https://wiki.php.net/rfc/fsync_function to under discussion, cheers.
>>
>> David Gebler
>> davidgebler@gmail.com
>>
>>
>> On Sat, Jan 30, 2021 at 1:58 AM David Gebler <davidgebler@gmail.com>
>> wrote:
>>
>>> Hi internals,
>>> Some time back I asked for commentary on a proposal to add fsync() to
>>> PHP, I have now submitted a draft RFC
>>> https://wiki.php.net/rfc/fsync_function alongside an in-progress proof
>>> of concept PR (current status: can compile locally and run but the branch
>>> needs more work to bring it up to standard, as well as tests and
>>> documentation) which I would like to open up for review and discussion.
>>>
>>> Thanks.
>>>
>>> David Gebler
>>> davidgebler@gmail.com
>>>
>>>

--0000000000001699ef05ba722dc7--