Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:113040 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 93385 invoked from network); 1 Feb 2021 17:52:57 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Feb 2021 17:52:57 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 24FDE1804D0 for ; Mon, 1 Feb 2021 09:35:57 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, HTML_FONT_LOW_CONTRAST,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 1 Feb 2021 09:35:56 -0800 (PST) Received: by mail-ot1-f49.google.com with SMTP id h14so17117669otr.4 for ; Mon, 01 Feb 2021 09:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=qC0EB8hLbYXe0VD2hnQJoh/QrIvHCFT0WQ6+RyqIC+8=; b=UK117z3dF2diIxEcl9VDNU+1wwUikt8MH6N83pMliNKyX3BhWvRqUg4izHxMycPEQD 6164cNSi5kEpwd6/xiUlQRzcttelIx62LtE472RvIEhs8kKvLAFK2zIAijJqv04SZZV8 hD+HxPJkhKQmkG+9fjFVWzehDvKEMG5TzrIHNgLdQs124THOhA+1GadTw52RsEKT1fPE k9CEeBr0RIaqRyJ2H1m9XRLTDTzXk+Rta6DjCWW4IX79gqrAfRKIhujTzUGkJnGeaU2H V2rODXSPhIWQVYVvrY1hwb1NpAN7LuEUNuFiUoTiOxTvhDST56bNhHXD2WbLw2T4gUH9 jwlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qC0EB8hLbYXe0VD2hnQJoh/QrIvHCFT0WQ6+RyqIC+8=; b=YRMleXkzQBwNn3U7ZJL/5RMMrmcnS2gyiAC5DyCaga4DHyO+khikPvHkepyCk89F8s YufM2/hnR9ZwKITrF+RDsYb5LxOGKV+0mPiemeZBaWLM2/LBp4MHx974oF8hVWJuRZdC Dj1kJrLnUmBRQQF9g0HEE/0RM4a7apBv8YiOx5PMFMxrVsy6bZ2JG0aUzmBqq5ZmB1sq A52Cz+v0zcdWHLpS4yBui6iPIO2QL22t0cH0AW16dbqSWkiUHI5IRZeODHlMD1hQX0AG eZ6mGGPEerB1kTTmJeMJinrUb8jHgPxopDvHoXcJySCAMvOS/AADrcy9UrZKfl1E6NaA f1qQ== X-Gm-Message-State: AOAM5306eQbZTY+BSfYjG1OEx6UgKlInzPX2Uqx8fFXgQwQ8vv11+FLp kd44r97ujDi72hcgosizmkZuUT8STPt9GecvylUsQhA3LgBeIg== X-Google-Smtp-Source: ABdhPJxw/MWoJsxlyYkUVnog2BM1KvQTl6TJjIiQmfzsyQfFslrVUjBRcIbvEHyvZd0XjzRFgwH/Vt+n5hIavp92DdE= X-Received: by 2002:a9d:7503:: with SMTP id r3mr4136610otk.236.1612200955661; Mon, 01 Feb 2021 09:35:55 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Mon, 1 Feb 2021 17:35:45 +0000 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="00000000000044d1cc05ba49c9a4" Subject: Re: [RFC]: fsync function From: davidgebler@gmail.com (David Gebler) --00000000000044d1cc05ba49c9a4 Content-Type: text/plain; charset="UTF-8" Hi internals, I have updated the GitHub PR and wiki RFC to also include an implementation of fdatasync. On another note, I note my PR builds are failing on MACOS_DEBUG_NTS with a test in ext/zend_test/tests/observer_error_05.phpt- this does not appear to be related to my changes and I'm wondering if anyone can shed any light on this? I'm seeing it on some other open PRs too so I'm guessing it's a known issue? Cheers. David Gebler davidgebler@gmail.com On Sat, Jan 30, 2021 at 6:34 PM David Gebler wrote: > Updated the PR https://github.com/php/php-src/pull/6650 following comment > from Nikita, added basic tests, would appreciate further review from > contributors, have updated the RFC https://wiki.php.net/rfc/fsync_function to > under discussion, cheers. > > David Gebler > davidgebler@gmail.com > > > On Sat, Jan 30, 2021 at 1:58 AM David Gebler > wrote: > >> Hi internals, >> Some time back I asked for commentary on a proposal to add fsync() to >> PHP, I have now submitted a draft RFC >> https://wiki.php.net/rfc/fsync_function alongside an in-progress proof >> of concept PR (current status: can compile locally and run but the branch >> needs more work to bring it up to standard, as well as tests and >> documentation) which I would like to open up for review and discussion. >> >> Thanks. >> >> David Gebler >> davidgebler@gmail.com >> >> --00000000000044d1cc05ba49c9a4--