Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113039
Content-Type: text/plain;
	charset=utf-8
In-Reply-To: <DM6PR07MB6618CACB8C7FBF81A2A66A8FF9A20@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Mon, 1 Feb 2021 16:40:05 +0100
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID:
 <VI1PR02MB470385256ADCA1CB1D21419EE2B69@VI1PR02MB4703.eurprd02.prod.outlook.com>
References: <DM6PR07MB6618CACB8C7FBF81A2A66A8FF9A20@DM6PR07MB6618.namprd07.prod.outlook.com>
To: tyson andre <tysonandre775@hotmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:7e8:c83a:5400:e90e:fe81:be2c:8c39] (2001:7e8:c83a:5400:e90e:fe81:be2c:8c39) by LO4P123CA0080.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17 via Frontend Transport; Mon, 1 Feb 2021 15:40:06 +0000
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 47
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: a6a794f0-5c25-412d-dead-08d8c6c7a6a5
X-MS-Exchange-SLBlob-MailProps:
	K3wx5smWY1PwvgS5FL6c7RmtiLKqTG5sS9tsba2MSGHsWmosyPrdAw/H2vbm5hlsmorwzGUYQOmF0OF/PnpUg4VZMA+IGj1+17j5Y6WcsFNkgtDdx7gc4D3Ov6VtnPhJk/+HTwJIrOlq09EgXziUvJDU02baLxepnejA8EHIEItcvp8GB/MiGPIJ2ShF+fwkRuDIFtT+EMRr5Hjavk2gh5UN86/uh8a8Wrjmr9eK7pMy/PNx6e0Dky4j+PcGLk1ukdiw4R6kfPdnvswt/zFa6KE4AAE2QvFgS5OWC464DZuunUCgzRV1wc8oD6SM4LB0ZrndsIZlfuYqAC90nItLPBuSjJJELOkB/i8Tt0ddQBXQGbihwTDQdjgqaAbvSm5re2PLTsf+NMvUEjh1NBbaOhvixKkBeYvjZKGr4XbTNlHQ3CHEcRSg8tWjjZJeDN0Nm5rKL98dcNpHjBaATWPpI2AecekxJxUWfZA2uybVlUhMUVnI+/0aZFWJa6Z9VRpJNuQzDwAjijckrkRxLziWuzN2oNqqWIOiHJL/9kZF2/PbdyzAwIn8YJg9qXAwjLMAyYu0boLCO8IJ9D2bFyha0ugCE/6DimUHDyFzWYYSf9JLIBrm1NXhQEIENF4ZKm9kCTM9t4Xlps/iD3Vnv6/PGIvaqV6o4iwvWgztz9H26zhaMqOlB8go7XR+ubx0h2po5fG0RVYycqxtV+Vw7KHlYVpUTFCl2dLf+CUHaBe1GaeaifKjQgBUIsMhDdAYzuZVRb2RUcxTyXWEyDqjR3/CNSOjahRPmKnpbCekKUcBbcWxIiD6E4xhUQ6r3QWx2eWHdq28FRwiSvysLBmM5OVkOSaBAWajZcg5TC+2axD75HvloNAf3INel7Ss20zP08fWTGl8FQsLvuvBvZaIIpp/mZ1gFNJoIKz3lKnljQFPeuM=
X-MS-TrafficTypeDiagnostic: DB8EUR06HT247:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	PyBHId5XeW0s7vhuxUaxDotI7tMfpNnXKo9UCpcX2UlGQMSjic1K5dTDg9wOKpccrJbQqOKSVV1ePukLuAl6Bqn7eU5YamysIJqyWM5CuQpLIlgBPzJmf+Bl/n1YVzGLevv/2rBXlGPtkJuMkkg0nKffVNC6Z26L1oMR5x2bJ3LjzjKpPjT5w+y1F4kqAicrmnhe6hpnrTGc57GeBCT4ic5QpNxkL09TdrNUyZdMEDAKaw7568pb6D6AcWIK/1qIbynvrx6L5oxtvwAE3ri6il2euRuckgHSqfKofEG7snxHsz+F7e8W11YgCIGe8bo99I3DsyF41ENufjRzAtgZgQ/4ihZ1ZGQy6FVF8Wet7FVu2mzeWyB/Tq7CBbEHkEhf5GurKG3E4NtsQhOiYgh3AZe+kV4SgIQ/CqZJmYth6IzwSH/xT/pjHinlNksTtJ3U
X-MS-Exchange-AntiSpam-MessageData:
	KerD8A9QzLeClUjBsdzeCprmx4rKEzkCzpNw+ceWKiyHknAi2THu+ME2j5og5VQdAn2SL5WXQdi9mo/mbPeDy9C3kdcxJ7nBDSgPhbxFLKXJD9rH0EKZPk8wdWXCZb+BAnxZKYp/d2nAqqqQLHVPpP5TIjTXesmcp8Ku/n5d7aJosYxXvca6Ki2bFcrtBa1k5wusotgQNvFZXftvkjKNNA==
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6a794f0-5c25-412d-dead-08d8c6c7a6a5
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2021 15:40:07.4322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-AuthSource:
	DB8EUR06FT020.eop-eur06.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR06HT247
Subject: Re: [PHP-DEV] [VOTE] Dump results of expressions in `php -a`
From: bobwei9@hotmail.com (Bob Weinand)

> Am 20.01.2021 um 01:55 schrieb tyson andre <tysonandre775@hotmail.com>:
>=20
> Hi internals,
>=20
> Voting has started on https://wiki.php.net/rfc/readline_interactive_shell=
_result_function
> on 2021-01-19, and ends on 2021-02-02.
>=20
> This RFC proposes to dump the results of non-null expressions using var_d=
ump/var_export() by default in `php -a` (the interactive shell).
> Additionally, this adds a new function `readline_interactive_shell_result=
_function` to the readline PHP module.
> This function only affects interactive shells - it can optionally be used=
 to set or clear a closure when `extension_loaded('readline') =3D=3D=3D tru=
e`,
> but that closure would only be called in interactive shells (i.e. php -a)=
.
> (That closure would be called instead of the native implementation with t=
he snippet of code that was evaluated and the expression's result,
> if a php statement contained a single expression such as `2+2;` or `$x =
=3D [1,2];` (that could be used as the expression of a return statement)
> - Dumping of expression results can be disabled using an ini setting or a=
t runtime=20
>=20
> Thanks,
> - Tyson

Hey Tyson,

My main concern in this iteration of the RFC is: what happens with big/deep=
ly nested objects?
They tend to spew tons of lines if var_dump()'ed. Do we have reasonable dep=
th/output limitations in default dumping mode?

I'm often enough using php -a to do some quick ad-hoc processing (example, =
read a big json file, and then access a value; instantiating a mediawiki bo=
t framework and calling replace on it; ...).

It's really cool to have any interactive feedback at all, but please, at le=
ast by default, limit the output. (An example is the JS REPL in browser con=
sole - it shows you a minimal preview of the object, and then you can expan=
d with your mouse. Obviously with a pure cli application, this needs differ=
ent - intuitive - navigation.)

As it currently stands, this makes php -a unusable in any but the simplest =
cases, without just disabling the whole feature.

I like the whole feature, but the missing output limitation (I have yet eno=
ugh nightmares from var_dump()'ing the wrong object filling my shell with t=
ons of irrelevant information=E2=80=A6 I don't need that potentially happen=
ing on every single evaluated expression)

Thus I'm voting no, for now.

Bob=