Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113017
To: Brent Roose <brendt@stitcher.io>, PHP Internals <internals@lists.php.net>
References: <88ABCF54-FA19-4273-9F04-FF6386758890@stitcher.io>
Message-ID: <95314eec-3926-9d08-001f-bc999ab6248f@processus.org>
Date: Fri, 29 Jan 2021 09:18:17 +0100
MIME-Version: 1.0
In-Reply-To: <88ABCF54-FA19-4273-9F04-FF6386758890@stitcher.io>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [PHP-DEV] [DISCUSSION] ReflectionType::accepts
From: pierre-php@processus.org ("Pierre R.")

Le 29/01/2021 à 09:14, Brent Roose a écrit :
> Hi Internals
>
> Since the addition of union types, it has become a little more cumbersome to determine whether a given parameter type accepts specific input. Personally I've been reusing this code blob in several places because of it:
>
> ```
> /** @var \ReflectionNamedType[] $types */
> $types = match ($type::class) {
>      ReflectionUnionType::class => $type->getTypes(),
>      ReflectionNamedType::class => [$type],
> };
>
> foreach ($types as $type) {
>      if (! is_subclass_of($type->getName(), ShouldBeStored::class)) {
>          continue;
>      }
>
>      // …
> }
> ```
>
> I wonder whether we would discuss adding a method on ReflectionType that accepts any given input, and tells you whether that input is valid for that type or not. I was thinking about `ReflectionType::accepts(string|object $input): bool` but we could discuss another name. With it, the above example could be refactored like so:
>
> ```
> if (! $type->accepts(ShouldBeStored::class)) {
>      return;
> }
>
> // …
> ```
>
> I believe this method should accept both class names and objects to be consistent with the existing reflection API. It would also work with intersection types, if they are to be added some day.
>
> What do you think?
>
> Kind regards
> Brent

Hello,

I think this would be a good addition. I personally had to write the 
exact same algorithm to solve this exact same problem yesterday night.

Cheers,

--

Pierre