Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113012
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com> <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com> <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
 <EFFA9BF8-1C86-42E4-9A13-8203B920C81A@cschneid.com> <CAFPFaMKH2rT=9E5ka5YP7DYjZ243QVj-Oj3Bm9kAoA=WBPH2bw@mail.gmail.com>
 <4D7D042F-39A5-4BEF-93B6-542FD53928A1@cschneid.com> <CAAwdEzD84xDnUsOLBTP_BfrT8s97GkOM-aQ7rk7R6x5OFcmVZw@mail.gmail.com>
 <73C12DD2-D99E-44BA-B557-6043F3DDD4C7@cschneid.com> <CAF+90c_QC6wbzQLop3Xyp1RUEeBVSttz6T9KgV4DBJmEL9hmpA@mail.gmail.com>
 <30C0E1A8-6269-4221-AF21-3FA738D5910C@cschneid.com> <CAGBsUrfePS2Gnh4xQMQFEnUVXGTdgMhaPP5reLLcKR+nEp59Yw@mail.gmail.com>
 <0eb16a55-92d0-7118-57fe-0f3f7d2bc351@telia.com>
In-Reply-To: <0eb16a55-92d0-7118-57fe-0f3f7d2bc351@telia.com>
Date: Thu, 28 Jan 2021 00:31:19 +0000
Message-ID: <CAGBsUrcEPmivXPTq=GHmPEuMwsadSPioV63=U6XnipZb4F6xjQ@mail.gmail.com>
To: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>
Cc: Christian Schneider <cschneid@cschneid.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003eb92c05b9eb0251"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: tekiela246@gmail.com (Kamil Tekiela)

--0000000000003eb92c05b9eb0251
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

>
> I'm missing a thing here when we talk about "your code". I mean on our
> site we have third party libraries. They can typically have a release
> schedule on a couple of releases each year. So all code is not up to
> us to change. So how does this proposal adress that scenario when it's
> not up to us to do the necessary changes? Is it e.g. a blocker to
> upgrade to PHP 8.1 with exceptions vs warnings until the library is
> updated?
>
> As a side note I'm at the moment migrating our test site to PHP 8 and
> the two most prominent hickups are located in a third party library:
> "Undefined array key" and "Attempt to read property "value" on null"
> which are warnings. Not sure how it would have been with these as
> exceptions, e.g. would the test site stop running and thereby stop
> testing of other parts.
>
> And as I have said earlier, I do like exceptions! It's the migration
> aspect I'm wondering about...
>
> r//Bj=C3=B6rn L
>

This is a valid concern. I have thought about it for a while and I think
that we should handle this the same way we did with PDO error mode change.
We don't do anything special.

I really don't see a way that we could make a smoother upgrading
experience. For users that avail of old libraries the onus is on them to
check the library's compatibility with the new PHP version. Ideally, the
change should have been made in PHP 8.0 where it would be more justifiable
to change a default setting.

The good thing about mysqli error reporting compared to PDO is that the
setting is global. If the library you are using is abandoned or you can't
wait for the library to be updated then you can set the error reporting
level in your own code. The only problem comes when you want to mix both
modes in the same code, but that is a huge code smell anyway. This means
that this change is not a blocker for the upgrade.

I think the proposal is good to be implemented in PHP 8.1 as it is now. But
if anyone thinks otherwise or has any ideas on how to improve I would
gladly take it into consideration. If there is any way that we could make
the migration smoother then it would be great.

Kamil

--0000000000003eb92c05b9eb0251--