Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113001
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com> <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com> <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
 <EFFA9BF8-1C86-42E4-9A13-8203B920C81A@cschneid.com> <CAFPFaMKH2rT=9E5ka5YP7DYjZ243QVj-Oj3Bm9kAoA=WBPH2bw@mail.gmail.com>
 <4D7D042F-39A5-4BEF-93B6-542FD53928A1@cschneid.com> <CAAwdEzD84xDnUsOLBTP_BfrT8s97GkOM-aQ7rk7R6x5OFcmVZw@mail.gmail.com>
 <73C12DD2-D99E-44BA-B557-6043F3DDD4C7@cschneid.com>
In-Reply-To: <73C12DD2-D99E-44BA-B557-6043F3DDD4C7@cschneid.com>
Date: Wed, 27 Jan 2021 14:34:43 +0100
Message-ID: <CAF+90c_QC6wbzQLop3Xyp1RUEeBVSttz6T9KgV4DBJmEL9hmpA@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: =?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?= <drealecs@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000080deab05b9e1d6cc"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000080deab05b9e1d6cc
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 26, 2021 at 8:42 AM Christian Schneider <cschneid@cschneid.com>
wrote:

> Am 26.01.2021 um 07:57 schrieb Alexandru P=C4=83tr=C4=83nescu <drealecs@g=
mail.com>:
> > There will be other parts that will require testing, whatever you do.
> Trying to optimize this to reduce the 1 line quick fix that could be easi=
ly
> read in the documentation at https://www.php.net/manual/en/migration81.ph=
p
> <https://www.php.net/manual/en/migration81.php> sounds to me like we're
> trying too hard to reduce this cost, ignoring others.
>
> The migration guides are already getting quite long, just have a look at
> https://www.php.net/manual/de/migration80.incompatible.php <
> https://www.php.net/manual/de/migration80.incompatible.php>
> "Just one more line" can add up and that's why I want to be able to
> proactively fix my code, not fixing it at the time of migration.
>
> If the error mode would be changed to warnings instead of exceptions firs=
t
> then every developer interested in best practices could and would already
> adapt their code. But they could do it gradually without the disruption o=
f
> hard fails looming over them.
>
> I just think giving developers a warning period (per default, not opt-in)
> is the right thing to do for BC breaks. [ Did I mention round()? ;-) ]
>
> I start to sound like a broken record, I'll leave it at that,
> - Chris
>

I think if you wanted to introduce an additional diagnostic step, the way
to go about it would be to issue a deprecation warning when creating a
connection without mysqli_report() having been explicitly called
beforehand. As others have said, the warning mode is pretty much entirely
useless, and what you really want (presumably) is to know about the places
where you need to explicitly call mysqli_report() to preserve the old
behavior (or explicitly switch to the new one).

Regards,
Nikita

--00000000000080deab05b9e1d6cc--