Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:113000
MIME-Version: 1.0
References: <CABTDVhCtBn7T0YyB+55Mxxz1UCYi7ov_Se2nX-Uxh3EmK4XkdA@mail.gmail.com>
 <CABTDVhC7f4B9eB5dd9avMNQvt9iNtKy6EyqpRJDZmhckyr48Lw@mail.gmail.com>
In-Reply-To: <CABTDVhC7f4B9eB5dd9avMNQvt9iNtKy6EyqpRJDZmhckyr48Lw@mail.gmail.com>
Date: Wed, 27 Jan 2021 15:24:36 +0200
Message-ID: <CAAwdEzAue3SAALTR3TPa0XipVy-pqtM2YXdc4+BjURYJhDQc4g@mail.gmail.com>
To: Go Kudo <zeriyoshi@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005245c405b9e1b2d8"
Subject: Re: [PHP-DEV] Re: [RFC] Object-scope RNG implementation
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--0000000000005245c405b9e1b2d8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 26, 2021 at 8:06 PM Go Kudo <zeriyoshi@gmail.com> wrote:

> RFCs have been reorganized and radically rewritten.
> https://wiki.php.net/rfc/object_scope_prng
>
> The implementation is unchanged, but the background has been explained in
> more detail and the execution speed has been re-verified with PHP 8.1-dev=
.
>
> The proposal seems to have been received relatively positively by
> externals, but there hasn't been much reaction. I'm unsure when I should
> start voting on this RFC.
>
> Regards,
> Go Kudo
>
> 2021=E5=B9=B41=E6=9C=889=E6=97=A5(=E5=9C=9F) 19:00 Go Kudo <zeriyoshi@gma=
il.com>:
>
> > Hi internals.
> >
> > I think I'm ready to discuss this RFC.
> > https://wiki.php.net/rfc/object_scope_prng
> >
> > Previous internals thread: https://externals.io/message/112525
> >
> > Now is the time to let me know what you think.
> >
> > Regards,
> > Go Kudo
> >
>

Hi  Go Kudo,

The closest library I know and used when I had that need you mentioned is a
userland implementation: https://github.com/paragonie/RandomLib, created
by Anthony Ferrara and not maintained by Paragon Initiative Enterprises.
The library is organized nicely with a Generator class that depends on
constructor of a source for randomness. The source has just a simple method
to obtain a specific number of bytes and that's all.

I think the naming is what needs more input here. I'm thinking we can also
have:
- a random bytes source/generator that can be very similar with what you
propose: an interface, multiple internal classes, allowing userland extra
classes.
- a random generator class that would have multiple useful methods like:
randomInt($min, $max), randomFloat(), randomBytes($size),
randomString($size, $possibleCharacters) etc.

As for namings, calling them
- RandomGenerator final class that accepts at constructor a
- RandomSource interface with one method getBytes($size) implemented by
RandomXorShift128PlusSource, RandomMT19937Source, RandomLibsodiumSource,
SecureOsSpecificSource etc.
is a quick idea from me.

State, when is the case, sits in the random source object and can be of
course serialized.

Other than this, initiative looks good.
I apologize if I provided the feedback a bit late.

Regards,
Alex

--0000000000005245c405b9e1b2d8--