Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112994
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com> <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com> <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
 <EFFA9BF8-1C86-42E4-9A13-8203B920C81A@cschneid.com> <CAFPFaMKH2rT=9E5ka5YP7DYjZ243QVj-Oj3Bm9kAoA=WBPH2bw@mail.gmail.com>
 <4D7D042F-39A5-4BEF-93B6-542FD53928A1@cschneid.com>
In-Reply-To: <4D7D042F-39A5-4BEF-93B6-542FD53928A1@cschneid.com>
Date: Tue, 26 Jan 2021 08:57:21 +0200
Message-ID: <CAAwdEzD84xDnUsOLBTP_BfrT8s97GkOM-aQ7rk7R6x5OFcmVZw@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: "G. P. B." <george.banyard@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000939bea05b9c82b0c"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000939bea05b9c82b0c
Content-Type: text/plain; charset="UTF-8"

On Mon, Jan 25, 2021 at 7:33 PM Christian Schneider <cschneid@cschneid.com>
wrote:

> Am 25.01.2021 um 18:22 schrieb G. P. B. <george.banyard@gmail.com>:
> > And yes I'm basically advocating for people to add
> mysqli_report(MYSQLI_REPORT_ERROR) (or even
> mysqli_report(MYSQLI_REPORT_OFF) if they fancy) to their setup, I'm even
> advocating for them to do it right now such that they can catch anything
> ahead of time.
>
> Defaults matter. Most people will *not* do this step and their code will
> fail on upgrade.
>
> > Moreover, this proposal does not prevent you from using the warning mode
> instead of jumping to exceptions directly, the key point is that you need
> to specify it, and I personally believe that having the warning mode as the
> default mode is the worst choice for the reasons I mentioned previously.
>
> Agree to disagree.
>
> If I have the choice to make the smoothen the transition centrally with
> PHP defaults or rely on each user to do it manually by proactively setting
> warning modes I prefer the defaults way.
>
> Remember: I am not advocating staying in the warning mode, I'm just seeing
> it as a useful intermediate step for legacy stuff we want to fix.
>
> - Chris
>
>
  Hi Chris,

I think PHP is far from targeting a zero cost on version upgrade for
projects.
There will be other parts that will require testing, whatever you do.
Trying to optimize this to reduce the 1 line quick fix that could be easily
read in the documentation at https://www.php.net/manual/en/migration81.php
sounds to me like we're trying too hard to reduce this cost, ignoring
others. Other technical costs would be to not switch earlier to new
exception mode as long as the default will cover the cases.

I am thinking about this with a legacy system in mind that is long due on
exception handling for the database layer. I know that having exceptions by
default would spark an interest in developers' minds to do this change
sooner rather than later because they will feel the default is the
recommended way. Due to bandwidth allocation, they might add the line
there, but a task will be created to fix it in the next few months, maybe a
year.

There will be a cost of upgrading. New scenarios and tests that might not
even exist currently, negative flow scenarios.

Regards,
Alex

--000000000000939bea05b9c82b0c--