Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112988
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\))
In-Reply-To: <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
Date: Mon, 25 Jan 2021 17:25:38 +0100
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <EFFA9BF8-1C86-42E4-9A13-8203B920C81A@cschneid.com>
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com>
 <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com>
 <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: cschneid@cschneid.com (Christian Schneider)

Am 25.01.2021 um 16:59 schrieb G. P. B. <george.banyard@gmail.com>:
> The BC break is totally minimal as it's a one line of code that needs =
to be added (and for all intent and purposes should already be done).

That does not change the fact that it is a BC break which should be =
treated accordingly.

You are basically advocating people should add =
mysqli_report(MYSQLI_REPORT_OFF) to their setup which will totally =
defeat the purpose of the change.
Or (probably more what you have in mind) that they should add =
mysqli_report(MYSQLI_REPORT_ERROR) now (to prepare for the change) and =
switch to MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT later once they =
know they are ready.
And this is exactly what I think should be done by the PHP default so =
people don't have to go through this manually.

> Moreover, I'd rather we get rid of the warning modes all together as =
they make the least sense to me.
> Either you're handling the failures explicitly anyway and you use the =
silent mode, or you don't and want it to throw with the exception mode.

This is where you are missing a key component: I want to go through a =
phase where I will notice parts where manual error handling (or =
exception handling after the change) is missing without having my =
application abort. This is what warnings are good for.

To some of us this is a very valuable step when upgrading.

- Chris