Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112987
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com> <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com> <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
In-Reply-To: <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
Date: Mon, 25 Jan 2021 17:10:10 +0100
Message-ID: <CAG9XoMTt7A3HFdsxH62YeAZxYMBijbAsrQjPqfwL59rpvGTFWg@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: Christian Schneider <cschneid@cschneid.com>, Kamil Tekiela <tekiela246@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000575a2b05b9bbc62d"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: benjamin.morel@gmail.com (Benjamin Morel)

--000000000000575a2b05b9bbc62d
Content-Type: text/plain; charset="UTF-8"

>
> Moreover, I'd rather we get rid of the warning modes all together as they
> make the least sense to me.
> Either you're handling the failures explicitly anyway and you use the
> silent mode, or you don't and want it to throw with the exception mode.
> The warning mode is literally the worst of both worlds, it doesn't fail on
> failure so you need to check for failure manually,
> and you need to suppress the warnings because otherwise you get false
> negatives.
>
> Best regards,
>
> George P. Banyard
>

I'd just like to say amen to that.

Please move as much code as possible to throwing exceptions, and get rid of
warnings. Most of the time when a warning is thrown in PHP, what you
actually want is to deal with it, or stop execution.

- Benjamin

--000000000000575a2b05b9bbc62d--