Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112986
MIME-Version: 1.0
References: <CAGBsUrddzJQu3JtqCdLjyHOBf71gj5LpNKuV=OmYGm0Vd3n9Yw@mail.gmail.com>
 <0edafce4-c9a5-c483-65f1-72e49614135a@telia.com> <CAGBsUreBNSkv7KY6FRw-c0SfWDMs9H+aTFG_e89wUSmf53DWkQ@mail.gmail.com>
 <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com>
In-Reply-To: <AAA0C162-26F9-4F06-8509-F3C96C0DAEA3@cschneid.com>
Date: Mon, 25 Jan 2021 15:59:18 +0000
Message-ID: <CAFPFaMJE-YzYv1nW9t8974CmigrmBtQTQR67BaQ7zbM0B1U4+g@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: Kamil Tekiela <tekiela246@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000082075205b9bb9f06"
Subject: Re: [PHP-DEV] [RFC]: Change Default mysqli Error Mode
From: george.banyard@gmail.com ("G. P. B.")

--00000000000082075205b9bb9f06
Content-Type: text/plain; charset="UTF-8"

On Mon, 25 Jan 2021 at 15:41, Christian Schneider <cschneid@cschneid.com>
wrote:

> Am 21.01.2021 um 23:46 schrieb Kamil Tekiela <tekiela246@gmail.com>:
> > In fact, I don't really see this as a major breaking change. If any
> project
> > really needs the mysqli errors silenced then they can just set the error
> > mode back to OFF. The change is aimed at new users, not existing
> projects.
> > Silenced error reporting was a source of confusion for plenty of
> beginners
> > who were unaware of the setting.
>
>
> As this definitely is a BC (applications stop running) I think we should
> go through a phase were it throws a warning instead of aborting, i.e.
> changing it to
>         mysqli_report(MYSQLI_REPORT_ERROR);
> first and change it to throw an exception after a grace period.
>
> This would be in line with most other newly introduced exceptions for the
> default configuration.
> Plus this would most certainly help people who host other people's
> websites who want to upgrade to PHP 8.x.
>
> PS: IMHO The same should be (retroactively) done with round() and friends!
>
> - Chris
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>
The BC break is totally minimal as it's a one line of code that needs to be
added (and for all intent and purposes should already be done).

Moreover, I'd rather we get rid of the warning modes all together as they
make the least sense to me.
Either you're handling the failures explicitly anyway and you use the
silent mode, or you don't and want it to throw with the exception mode.
The warning mode is literally the worst of both worlds, it doesn't fail on
failure so you need to check for failure manually,
and you need to suppress the warnings because otherwise you get false
negatives.

Best regards,

George P. Banyard

--00000000000082075205b9bb9f06--