Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112906
To: James Colannino <composer@colannino.dev>, internals@lists.php.net
References: <90e4acaa-899d-9a20-1653-f58a2a04aeb6@colannino.dev>
 <CAF+90c9vUukaH76paRb_0OgdG++F87p3W_LbC5EhAZJNuGp7Yw@mail.gmail.com>
 <d09939d6-d2c4-7063-16dc-75157ad7acac@colannino.dev>
 <c5781da5-6448-fba6-d76e-7729ff0dc514@colannino.dev>
Message-ID: <76a97cce-8707-48aa-763b-20970eaa18db@gmx.de>
Date: Fri, 15 Jan 2021 19:17:13 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <c5781da5-6448-fba6-d76e-7729ff0dc514@colannino.dev>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Arg info / zpp mismatch on PHP 8.0
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 15.01.2021 at 18:40, James Colannino wrote:

> On 1/15/21 9:20 AM, James Colannino wrote:
>>
>> On 1/15/21 9:15 AM, Nikita Popov wrote:
>>> On Fri, Jan 15, 2021 at 6:11 PM James Colannino <composer@colannino.de=
v>
>>> wrote:
>>>
>>>> I have the following method defined in a PHP 8 extension:
>>>>
>>>> ZEND_BEGIN_ARG_INFO(arginfoCtor, 0)
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ZEND_ARG_TYPE_INFO(0, hostname, IS_STR=
ING, 0)
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1=
)
>>>> ZEND_END_ARG_INFO()
>>>>
>>>> PHP_METHOD(Trogdord, __construct) {
>>>>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 trogdordObject *objWrapper =3D
>>>> ZOBJ_TO_TROGDORD(Z_OBJ_P(getThis()));
>>>>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 char *hostname;
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 size_t hostnameLength;
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 long port =3D TROGDORD_DEFAULT_PORT;
>>>>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 zend_parse_parameters_throw(
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ZEND_NUM_ARGS(=
),
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "s|l",
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &hostname,
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &hostnameLengt=
h,
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &port
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 );
>>>>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ...
>>>> }
>>>>
>>>> This works fine on PHP 7, but on PHP 8, I get an "Arg info / zpp
>>>> mismatch" error. I discovered that if I comment out
>>>> "ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)", it works, but I'd like to
>>>> type hint that second optional argument if possible. Maybe I was alwa=
ys
>>>> doing this the wrong way, but I thought that the last argument 1 to
>>>> allow null was the proper way to handle this and I'm not sure why it
>>>> results in an error now.
>>>>
>>>> Can anyone tell me the correct way to approach this in PHP 8? Thank
>>>> you!
>>>>
>>> Your arginfo declares the arugment as nullable, but your zpp call
>>> does not.
>>> Thus the error. You need:
>>>
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 zend_bool port_is_null =3D 1;
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 zend_parse_parameters_throw(
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ZEND_NUM_ARGS()=
,
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "s|l!", // ! me=
ans nullable
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &hostname,
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &hostnameLength=
,
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &port,
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 &port_is_null /=
/ Whether null was actually passed
>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 );
>>
>>
>> I tried that, but I still get the "Arginfo / zpp mismatch during call"
>> error.
>
>
> This is the code I have now, which is still giving me the error on PHP 8=
:
>
> ZEND_BEGIN_ARG_INFO(arginfoCtor, 0)

You need to tell arginfo about the optional parameter:

ZEND_BEGIN_ARG_INFO_EX(arginfoCtor, 0, 0, 1)

However, it is much simpler to write a stub file, and to let
build/gen_stub.php generate the arginfo for you.  See e.g.
<https://github.com/php/php-src/blob/master/ext/standard/basic_functions.s=
tub.php>.

> =C2=A0=C2=A0=C2=A0 ZEND_ARG_TYPE_INFO(0, hostname, IS_STRING, 0)
> =C2=A0=C2=A0=C2=A0 ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)
> ZEND_END_ARG_INFO()
>
> PHP_METHOD(Trogdord, __construct) {
>
> =C2=A0=C2=A0=C2=A0 trogdordObject *objWrapper =3D ZOBJ_TO_TROGDORD(Z_OBJ=
_P(getThis()));
>
> =C2=A0=C2=A0=C2=A0 char *hostname;
> =C2=A0=C2=A0=C2=A0 size_t hostnameLength;
>
> =C2=A0=C2=A0=C2=A0 long port =3D TROGDORD_DEFAULT_PORT;
> =C2=A0=C2=A0=C2=A0 zend_bool portIsNull =3D 1;
>
> =C2=A0=C2=A0=C2=A0 zend_parse_parameters_throw(
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 ZEND_NUM_ARGS(),
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "s|l!",
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 &hostname,
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 &hostnameLength,
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 &port,
> =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 &portIsNull
> =C2=A0=C2=A0=C2=A0 );
>
> =C2=A0=C2=A0=C2=A0 ...
> }