Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112903
MIME-Version: 1.0
References: <90e4acaa-899d-9a20-1653-f58a2a04aeb6@colannino.dev>
In-Reply-To: <90e4acaa-899d-9a20-1653-f58a2a04aeb6@colannino.dev>
Date: Fri, 15 Jan 2021 18:15:08 +0100
Message-ID: <CAF+90c9vUukaH76paRb_0OgdG++F87p3W_LbC5EhAZJNuGp7Yw@mail.gmail.com>
To: composer@colannino.dev
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008e1ae405b8f384a9"
Subject: Re: [PHP-DEV] Arg info / zpp mismatch on PHP 8.0
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000008e1ae405b8f384a9
Content-Type: text/plain; charset="UTF-8"

On Fri, Jan 15, 2021 at 6:11 PM James Colannino <composer@colannino.dev>
wrote:

> I have the following method defined in a PHP 8 extension:
>
> ZEND_BEGIN_ARG_INFO(arginfoCtor, 0)
>      ZEND_ARG_TYPE_INFO(0, hostname, IS_STRING, 0)
>      ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)
> ZEND_END_ARG_INFO()
>
> PHP_METHOD(Trogdord, __construct) {
>
>      trogdordObject *objWrapper = ZOBJ_TO_TROGDORD(Z_OBJ_P(getThis()));
>
>      char *hostname;
>      size_t hostnameLength;
>      long port = TROGDORD_DEFAULT_PORT;
>
>      zend_parse_parameters_throw(
>          ZEND_NUM_ARGS(),
>          "s|l",
>          &hostname,
>          &hostnameLength,
>          &port
>      );
>
>      ...
> }
>
> This works fine on PHP 7, but on PHP 8, I get an "Arg info / zpp
> mismatch" error. I discovered that if I comment out
> "ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)", it works, but I'd like to
> type hint that second optional argument if possible. Maybe I was always
> doing this the wrong way, but I thought that the last argument 1 to
> allow null was the proper way to handle this and I'm not sure why it
> results in an error now.
>
> Can anyone tell me the correct way to approach this in PHP 8? Thank you!
>

Your arginfo declares the arugment as nullable, but your zpp call does not.
Thus the error. You need:

     zend_bool port_is_null = 1;
     zend_parse_parameters_throw(
         ZEND_NUM_ARGS(),
         "s|l!", // ! means nullable
         &hostname,
         &hostnameLength,
         &port,
         &port_is_null // Whether null was actually passed
     );

Regards,
Nikita

--0000000000008e1ae405b8f384a9--