Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112902
To: internals@lists.php.net
Message-ID: <90e4acaa-899d-9a20-1653-f58a2a04aeb6@colannino.dev>
Date: Fri, 15 Jan 2021 09:10:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
Content-Type: multipart/alternative;
 boundary="------------C3E440E0A0E64428A4F933C8"
Content-Language: en-US
Subject: Arg info / zpp mismatch on PHP 8.0
From: composer@colannino.dev (James Colannino)

--------------C3E440E0A0E64428A4F933C8
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

I have the following method defined in a PHP 8 extension:

ZEND_BEGIN_ARG_INFO(arginfoCtor, 0)
     ZEND_ARG_TYPE_INFO(0, hostname, IS_STRING, 0)
     ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)
ZEND_END_ARG_INFO()

PHP_METHOD(Trogdord, __construct) {

     trogdordObject *objWrapper = ZOBJ_TO_TROGDORD(Z_OBJ_P(getThis()));

     char *hostname;
     size_t hostnameLength;
     long port = TROGDORD_DEFAULT_PORT;

     zend_parse_parameters_throw(
         ZEND_NUM_ARGS(),
         "s|l",
         &hostname,
         &hostnameLength,
         &port
     );

     ...
}

This works fine on PHP 7, but on PHP 8, I get an "Arg info / zpp 
mismatch" error. I discovered that if I comment out 
"ZEND_ARG_TYPE_INFO(0, port, IS_LONG, 1)", it works, but I'd like to 
type hint that second optional argument if possible. Maybe I was always 
doing this the wrong way, but I thought that the last argument 1 to 
allow null was the proper way to handle this and I'm not sure why it 
results in an error now.

Can anyone tell me the correct way to approach this in PHP 8? Thank you!


--------------C3E440E0A0E64428A4F933C8--