Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112898
MIME-Version: 1.0
References: <deff4418-5c66-4f19-ba25-b2c267e8b53f@www.fastmail.com>
In-Reply-To: <deff4418-5c66-4f19-ba25-b2c267e8b53f@www.fastmail.com>
Date: Thu, 14 Jan 2021 23:27:44 +0000
Message-ID: <CA+kxMuS-xWc+An2ziX57CJOn43-oJdjjxcZzWpyW0Bw-k3g4kA@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] "TryX" idom for Enumerations
From: Danack@basereality.com (Dan Ackroyd)

On Sun, 10 Jan 2021 at 21:28, Larry Garfield <larry@garfieldtech.com> wrote:
>
>
>  making a valueOrDefault() method unnecessary.
>
> $order = SortOrder::tryFrom($input) ?? SortOrder::Asc;
>

tbh, I would prefer a valueOrDefault() method, partly because it's
what I'm used to in my own code* but also I think it would be easier
to explain to a junior, or for a junior to remember.

cheers
Dan
Ack


*interface VarMap
{
    /**
     * @param string $name
     * @return mixed
     * @throws \VarMap\Exception\VariableMissingException
     */
    public function get(string $name);

    /**
     * @param string $name
     * @return bool
     */
    public function has(string $name) : bool;

    /**
     * @param string $name
     * @param mixed $defaultValue
     * @return mixed
     */
    public function getWithDefault(string $name, $defaultValue);

}